| commit | 4eb879133a06c86869dc54cecf904f4b1d46c47b | [log] [tgz] |
|---|---|---|
| author | Aart Bik <ajcbik@google.com> | Tue Sep 18 19:20:33 2018 +0000 |
| committer | commit-bot@chromium.org <commit-bot@chromium.org> | Tue Sep 18 19:20:33 2018 +0000 |
| tree | b35f42c8458902e955c4c614a635af37c9db50ba | |
| parent | 4611ebaec54c7e54006aed922c4b9333253c06e2 [diff] |
Revert "[vm/compiler] Restrict !(x>y) -> (x<=y) to integral x,y"
This reverts commit 0471d7e3a1b8e3b4d056df39310e9853c5eb8ad6.
Reason for revert: crashes are happening on the Nullable test
I will fix this in the follow-up CL that was
already pending
Original change's description:
> [vm/compiler] Restrict !(x>y) -> (x<=y) to integral x,y
>
> Rationale:
> Bug found with fuzz testing! For FP, behavior around
> NaN must be preserved.
>
> Bug: https://github.com/dart-lang/sdk/issues/34466
>
>
> Change-Id: Ia4ed831fc130e58318edb838bd46e30b93f62ff3
> Reviewed-on: https://dart-review.googlesource.com/75208
> Commit-Queue: Aart Bik <ajcbik@google.com>
> Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
TBR=vegorov@google.com,alexmarkov@google.com,sjindel@google.com,asiva@google.com,ajcbik@google.com
Change-Id: Ie2e233a612cbe00478475d086eec87ff2b3d652b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: https://github.com/dart-lang/sdk/issues/34466
Reviewed-on: https://dart-review.googlesource.com/75383
Reviewed-by: Aart Bik <ajcbik@google.com>
Commit-Queue: Aart Bik <ajcbik@google.com>
Dart is an open-source, scalable programming language, with robust libraries and runtimes, for building web, server, and mobile apps.
Visit the dartlang.org to learn more about the language, tools, getting started, and more.
Browse pub.dartlang.org for more packages and libraries contributed by the community and the Dart team.
If you want to build Dart yourself, here is a guide to getting the source, preparing your machine to build the SDK, and building.
There are more documents on our wiki.
The easiest way to contribute to Dart is to file issues.
You can also contribute patches, as described in Contributing.