commit dae49a0ca24a0856488291279774bb4ebbdebc2c
author asiva <asiva@google.com> Fri Feb 03 23:35:53 2023 +0000
committer Commit Queue <dart-scoped@luci-project-accounts.iam.gserviceaccount.com> Fri Feb 03 23:35:53 2023 +0000
tree 0bd2571e306f6040204f0dc5bb008061f513691a
parent 87810072db06c1a16fdaa7bf6bb77ef4e6405af5

[VM/Coverage] Fix memory leak in coverage code.

TEST=ci (existing test which was failing and should pass now)

Bug:51209
Change-Id: Ia156200af2b1271677f0a8ff576998b255adc964
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/280600
Commit-Queue: Siva Annamalai <asiva@google.com>
Reviewed-by: Liam Appelbe <liama@google.com>

runtime/vm/source_report.cc

diff --git a/runtime/vm/source_report.cc b/runtime/vm/source_report.cc
index 3b6d4c3..737a9a8 100644
--- a/runtime/vm/source_report.cc
+++ b/runtime/vm/source_report.cc
@@ -55,12 +55,20 @@
 }
 
 void SourceReport::ClearScriptTable() {
+  // Delete entries from script_table_ as it has the unfiltered list.
+  DirectChainedHashMap<ScriptTableTrait>::Iterator iter =
+      script_table_.GetIterator();
+  ScriptTableTrait::Pair* pair;
+  while ((pair = iter.Next()) != nullptr) {
+    delete ScriptTableTrait::ValueOf(*pair);
+  }
+  script_table_.Clear();
+
   for (intptr_t i = 0; i < script_table_entries_.length(); i++) {
-    delete script_table_entries_[i];
     script_table_entries_[i] = NULL;
   }
   script_table_entries_.Clear();
-  script_table_.Clear();
+
   next_script_index_ = 0;
 }