commit da8ed2208ec38a656b0ae2586e7ad426f5b4187a
author Danny Tuppeny <danny@tuppeny.com> Mon Oct 13 09:19:06 2025 -0700
committer Commit Queue <dart-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon Oct 13 09:19:06 2025 -0700
tree d9711810ac0539b9e87e1aab1203615e800772bb
parent 278ea48c7eec8ecd55124375cc3fc3fb5808ab22

[dds/dap] Prevent exceptions writing to stdout.nonBlocking from going unhandled

Because we use `nonBlocking`, the stream closing with unflushed data can result in an unhandled exception. Since we're never interested in errors writing to the stream (there's nothing we can do if the output stream is closed, and it happens at the end of every session), we just discard the error.

Fixes https://github.com/dart-lang/sdk/issues/61193
Fixes https://github.com/dart-lang/sdk/issues/55685
Fixes https://github.com/dart-lang/sdk/issues/55313

Change-Id: I6e0a332708cd6e8eb3ae8bd60d45c9e117d897a6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/452440
Reviewed-by: Ben Konyi <bkonyi@google.com>
Reviewed-by: Helin Shiah <helinx@google.com>
Commit-Queue: Helin Shiah <helinx@google.com>

pkg/dartdev/lib/src/commands/debug_adapter.dart

diff --git a/pkg/dartdev/lib/src/commands/debug_adapter.dart b/pkg/dartdev/lib/src/commands/debug_adapter.dart
index 378bde9..941d335 100644
--- a/pkg/dartdev/lib/src/commands/debug_adapter.dart
+++ b/pkg/dartdev/lib/src/commands/debug_adapter.dart
@@ -67,6 +67,12 @@
     final args = argResults!;
     final ipv6 = args.flag(argIpv6);
 
+    // Because we use stdout.nonBlocking, exceptions may go unhandled if the
+    // stream closes while data is being flushed ("The pipe is being closed").
+    // To prevent this, install an error handler that ignores any errors writing
+    // to the stream.
+    stdout.nonBlocking.done.catchError((e) {});
+
     final server = DapServer(
       stdin,
       stdout.nonBlocking,

pkg/dds/test/dap/integration/debug_attach_test.dart

diff --git a/pkg/dds/test/dap/integration/debug_attach_test.dart b/pkg/dds/test/dap/integration/debug_attach_test.dart
index 6e0b2ce..38d07e7 100644
--- a/pkg/dds/test/dap/integration/debug_attach_test.dart
+++ b/pkg/dds/test/dap/integration/debug_attach_test.dart
@@ -13,12 +13,7 @@
   group('debug mode', () {
     late DapTestSession dap;
     setUp(() async {
-      dap = await DapTestSession.setUp(
-        /// This boolean is temporarily set to `true` to aid debugging
-        /// https://github.com/dart-lang/sdk/issues/55313 and will be reverted
-        /// soon.
-        forceVerboseLogging: true,
-      );
+      dap = await DapTestSession.setUp();
     });
     tearDown(() => dap.tearDown());
 

pkg/dds/test/dap/integration/debug_exceptions_test.dart

diff --git a/pkg/dds/test/dap/integration/debug_exceptions_test.dart b/pkg/dds/test/dap/integration/debug_exceptions_test.dart
index 916675a..ae220d5 100644
--- a/pkg/dds/test/dap/integration/debug_exceptions_test.dart
+++ b/pkg/dds/test/dap/integration/debug_exceptions_test.dart
@@ -12,9 +12,7 @@
   group('debug mode', () {
     late DapTestSession dap;
     setUp(() async {
-      // Temporarily enable verbose logging to help track down
-      // https://github.com/dart-lang/sdk/issues/55685
-      dap = await DapTestSession.setUp(forceVerboseLogging: true);
+      dap = await DapTestSession.setUp();
     });
     tearDown(() => dap.tearDown());
 
@@ -57,7 +55,7 @@
       // Run the app and expect it to complete (it should not pause).
       final outputEvents = await client.collectOutput(file: testFile);
 
-      // Expect error info printed to stderr.
+      // Expect error info sent to stdout via `print()`.
       final output = outputEvents
           .where((e) => e.category == 'stdout')
           .map((e) => e.output)