commit d9fdec8129d7ed51a451e9da2568cf0fa534ab29
author Devon Carew <devoncarew@google.com> Mon Mar 20 17:25:43 2023 +0000
committer Commit Queue <dart-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon Mar 20 17:25:43 2023 +0000
tree b291953dd348ab7aeb7a93c13459fde6a294e56e
parent a62bfec074e6ac782928c2e5dd4a5429da668191

[sdk] no longer generate <sdk>/lib/_internal/strong.sum

Change-Id: I54d9e8751508db2602a142d0977c4e3b9381ac33
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/289443
Reviewed-by: Ben Konyi <bkonyi@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>

sdk/BUILD.gn

diff --git a/sdk/BUILD.gn b/sdk/BUILD.gn
index 2dae897..edaf4bc 100644
--- a/sdk/BUILD.gn
+++ b/sdk/BUILD.gn
@@ -54,7 +54,6 @@
 # ........kernel_worker.dart.snapshot
 # ......resources/
 # ........dartdoc/
-# ...........packages
 # ..........resources/
 # ..........templates/
 # ....include/
@@ -64,7 +63,6 @@
 # ....lib/
 # ......libraries.json
 # ......_internal/
-# ........strong.sum
 # ........dart2js_platform.dill
 # ........dart2js_platform_unsound.dill
 # ........dart2js_server_platform.dill
@@ -441,18 +439,6 @@
   ]
 }
 
-# This rule copies analyzer summaries to lib/_internal
-copy("copy_analysis_summaries") {
-  visibility = [ ":create_common_sdk" ]
-  deps = [
-    ":copy_libraries",
-    "../utils/dartanalyzer:generate_summary_strong",
-  ]
-  sources = [ "$root_gen_dir/strong.sum" ]
-  outputs =
-      [ "$root_out_dir/$dart_sdk_output/lib/_internal/{{source_file_part}}" ]
-}
-
 # This rule copies dill files to lib/_internal.
 copy("copy_vm_dill_files") {
   visibility = [ ":create_common_sdk" ]
@@ -628,10 +614,7 @@
 
 # This rule writes the version file.
 action("write_version_file") {
-  visibility = [
-    ":create_common_sdk",
-    "../utils/dartanalyzer:generate_summary_strong",
-  ]
+  visibility = [ ":create_common_sdk" ]
   inputs = [
     "../tools/VERSION",
     "$default_git_folder/logs/HEAD",
@@ -699,7 +682,6 @@
     ":create_sdk",
   ]
   public_deps = [
-    ":copy_analysis_summaries",
     ":copy_api_readme",
     ":copy_dart",
     ":copy_dartdev_dill_files",

utils/dartanalyzer/BUILD.gn

diff --git a/utils/dartanalyzer/BUILD.gn b/utils/dartanalyzer/BUILD.gn
index 87291fd..5ce231e 100644
--- a/utils/dartanalyzer/BUILD.gn
+++ b/utils/dartanalyzer/BUILD.gn
@@ -8,45 +8,11 @@
 import("../create_timestamp.gni")
 
 group("dartanalyzer") {
-  deps = [
-    ":generate_dartanalyzer_snapshot",
-    ":generate_summary_strong",
-  ]
+  deps = [ ":generate_dartanalyzer_snapshot" ]
 }
 
 application_snapshot("generate_dartanalyzer_snapshot") {
   main_dart = "../../pkg/analyzer_cli/bin/analyzer.dart"
-  training_args = [
-    "--help",
-    # TODO(34616): This is broken on Fuchsia.
-    # "--dart-sdk=" + rebase_path("../../sdk/"),
-    # "--train-snapshot",
-    # rebase_path("../../tests/language_2/first_test.dart")
-  ]
+  training_args = [ "--help" ]
   name = "dartanalyzer"
 }
-
-sdk_root = "../../sdk"
-
-create_timestamp_file("sdk_lib_files") {
-  path = rebase_path("$sdk_root/lib")
-  output = "$target_gen_dir/sdk_lib_files.stamp"
-}
-
-prebuilt_dart_action("generate_summary_strong") {
-  deps = [
-    ":sdk_lib_files",
-    "../../sdk:copy_libraries",
-    "../../sdk:write_version_file",
-  ]
-  script = "../../pkg/analyzer/tool/summary/build_sdk_summaries.dart"
-  packages = "../../.dart_tool/package_config.json"
-  output = "$root_gen_dir/strong.sum"
-  outputs = [ output ]
-  vm_args = [ "-Dsdk_hash=$sdk_hash" ]
-  args = [
-    "build",
-    rebase_path(output),
-    rebase_path("$root_out_dir/$dart_sdk_output"),
-  ]
-}