)]}' { "commit": "d7fa5f3d8965268cfd0ecdf53c67a6540494ac32", "tree": "4697cac16792bea81eb2fc56e9613c07ac3ab95a", "parents": [ "1569e88983b4fdd650a4082e5b194e26d480174c" ], "author": { "name": "Nate Biggs", "email": "natebiggs@google.com", "time": "Wed Nov 15 19:15:29 2023 +0000" }, "committer": { "name": "Commit Queue", "email": "dart-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed Nov 15 19:15:29 2023 +0000" }, "message": "Reland \"[dart2js] Evaluate CFE consts as part of phase 0b (CFE linker).\"\n\nThis is a reland of commit bebd08746b1461b031791ae8fa3c05c7d7516195\n\nOriginal change\u0027s description:\n\u003e [dart2js] Evaluate CFE consts as part of phase 0b (CFE linker).\n\u003e\n\u003e Constants are current evaluated in a few places during closed world generation, primarily as part of the ScopeModelBuilder. The scope visitor was modifying the AST which meant we had to emit a new dill with these evaluated constants along with the closed world results.\n\u003e\n\u003e This change instead evaluates the constants directly after linking the Kernel as part of the global transformations. This means we can update the ScopeModelBuilder to not mutate the AST at all as all constants are already simplified.\n\u003e\n\u003e A potential follow up here is to simplify the ScopeModelBuilder since all nodes should already be simplified if they can be, we should be able to avoid visiting some children.\n\u003e\n\u003e After this change we only directly create a single ConstantEvaluator, the one in `load_kernel`. The const simplifier also creates one and a follow up CL moves this to to run right after this new transformation.\n\u003e\n\u003e Note: Alternate versions of this CL tried to make the global transformation simpler by either:\n\u003e 1) Running the const evaluator indiscriminately on all expressions. This didn\u0027t work because it lead to exponential computation on constants set up as a DAG (see tests/language/const/constant_dag_test).\n\u003e 2) Only evaluating ConstantExpression nodes to update UnevaluatedConstants. This does not cover all the cases where the ScopeModelBuilder is modifying the tree and lead to a different compiler output.\n\u003e\n\u003e Change-Id: I746d889b37feddc9ab6c386c6252016dec745e6e\n\u003e Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/332601\n\u003e Reviewed-by: Mayank Patke \u003cfishythefish@google.com\u003e\n\nChange-Id: I53871a57144a3a1bd363af141d8f31c8ffa5ca6d\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/336221\nReviewed-by: Mayank Patke \u003cfishythefish@google.com\u003e\nCommit-Queue: Nate Biggs \u003cnatebiggs@google.com\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "7f59d40d95117f1772337658f210a2a6731115e2", "old_mode": 33188, "old_path": "pkg/compiler/lib/src/compiler.dart", "new_id": "ee7c2af62ca71aea5561cb24b924ab9aef45debb", "new_mode": 33188, "new_path": "pkg/compiler/lib/src/compiler.dart" }, { "type": "modify", "old_id": "55a2b47ff8a11b84d40c2a674765511b7498369a", "old_mode": 33188, "old_path": "pkg/compiler/lib/src/diagnostics/diagnostic_listener.dart", "new_id": "ec8c7d03e67ba14f6f5c2237f78aa45d00a0c6e1", "new_mode": 33188, "new_path": "pkg/compiler/lib/src/diagnostics/diagnostic_listener.dart" }, { "type": "modify", "old_id": "b9fb545942c964f158e85691991613d6b71aee99", "old_mode": 33188, "old_path": "pkg/compiler/lib/src/ir/annotations.dart", "new_id": "70ca9a23c4eb05870a9a939558eb3cb702057eb6", "new_mode": 33188, "new_path": "pkg/compiler/lib/src/ir/annotations.dart" }, { "type": "modify", "old_id": "9007ad781374cf04db5937d212a21b5f8fd95914", "old_mode": 33188, "old_path": "pkg/compiler/lib/src/ir/impact_data.dart", "new_id": "187e1a4edf6a9c0022b5b8535c5f3bdbb821318b", "new_mode": 33188, "new_path": "pkg/compiler/lib/src/ir/impact_data.dart" }, { "type": "modify", "old_id": "c746ded0b17b9d33e45d64c03484bdf133eaf688", "old_mode": 33188, "old_path": "pkg/compiler/lib/src/ir/modular.dart", "new_id": "313a51b703f57f1bf02fe611fe3a4fa0867f53cb", "new_mode": 33188, "new_path": "pkg/compiler/lib/src/ir/modular.dart" }, { "type": "modify", "old_id": "2c004c613a123332756b82add7b4171498d077ba", "old_mode": 33188, "old_path": "pkg/compiler/lib/src/ir/scope.dart", "new_id": "01bcc84f4565764e17c994072e278822e65a637a", "new_mode": 33188, "new_path": "pkg/compiler/lib/src/ir/scope.dart" }, { "type": "modify", "old_id": "2f4b26ef21f0bdc7410c9e225bed54ac3c9263fc", "old_mode": 33188, "old_path": "pkg/compiler/lib/src/ir/scope_visitor.dart", "new_id": "463dc888a8f0f2c874198d57e556ccf13d0de44b", "new_mode": 33188, "new_path": "pkg/compiler/lib/src/ir/scope_visitor.dart" }, { "type": "modify", "old_id": "a1ce9105b935ca3ab56ecc7dce73363b475522c7", "old_mode": 33188, "old_path": "pkg/compiler/lib/src/js_model/element_map_impl.dart", "new_id": "5ea8aaac0b8e53724cbef6fb22a727fa93247572", "new_mode": 33188, "new_path": "pkg/compiler/lib/src/js_model/element_map_impl.dart" }, { "type": "modify", "old_id": "c84eba86fe9a0346a3662f706562ae133166be75", "old_mode": 33188, "old_path": "pkg/compiler/lib/src/js_model/js_strategy.dart", "new_id": "11b3b4441d9a2aab74c830272e3346fa6ab7bcfa", "new_mode": 33188, "new_path": "pkg/compiler/lib/src/js_model/js_strategy.dart" }, { "type": "modify", "old_id": "fd955ef9d07b40779a9d08bd4f9abe6916f96472", "old_mode": 33188, "old_path": "pkg/compiler/lib/src/js_model/js_world.dart", "new_id": "d8ea1ca5cf96857cb4cd52cc7b6298a8e07c50ad", "new_mode": 33188, "new_path": "pkg/compiler/lib/src/js_model/js_world.dart" }, { "type": "modify", "old_id": "49ed8735f39acfb347d4b9c4bb0ed7bcaaf4d338", "old_mode": 33188, "old_path": "pkg/compiler/lib/src/kernel/element_map_impl.dart", "new_id": "360a5819229b6823de0f07b80989e40e4bb2e2fa", "new_mode": 33188, "new_path": "pkg/compiler/lib/src/kernel/element_map_impl.dart" }, { "type": "modify", "old_id": "cd08bd0de1868e99ae7877b89261cabcdd48df3b", "old_mode": 33188, "old_path": "pkg/compiler/lib/src/kernel/kernel_strategy.dart", "new_id": "33982b95171be7296062c9a2184aa2c60e94e3b5", "new_mode": 33188, "new_path": "pkg/compiler/lib/src/kernel/kernel_strategy.dart" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "57511f5628f8a350c0bd09d27a404fe3ebe962f7", "new_mode": 33188, "new_path": "pkg/compiler/lib/src/kernel/transformations/global/constant_transformer.dart" }, { "type": "modify", "old_id": "e4834b773d837d91ab2dd2223fc64b0f66b1db48", "old_mode": 33188, "old_path": "pkg/compiler/lib/src/kernel/transformations/global/js_get_flag_lowering.dart", "new_id": "26231749e9aa7c75f16183860e0074afdd369700", "new_mode": 33188, "new_path": "pkg/compiler/lib/src/kernel/transformations/global/js_get_flag_lowering.dart" }, { "type": "modify", "old_id": "983714d56bf4924b165de67efa4f624633efb613", "old_mode": 33188, "old_path": "pkg/compiler/lib/src/kernel/transformations/global/transform.dart", "new_id": "96ea8b1357300cf0c4c5570768de12f278b27a88", "new_mode": 33188, "new_path": "pkg/compiler/lib/src/kernel/transformations/global/transform.dart" }, { "type": "modify", "old_id": "d678507b9d6f2edee99120ee9d46de3f0e99e454", "old_mode": 33188, "old_path": "pkg/compiler/lib/src/phase/load_kernel.dart", "new_id": "135fb6cfb0afbb69b03052d84b59a0a1bb5ad967", "new_mode": 33188, "new_path": "pkg/compiler/lib/src/phase/load_kernel.dart" }, { "type": "modify", "old_id": "167c626dce23c81e85069e8a56ee4051b3053d9d", "old_mode": 33188, "old_path": "pkg/compiler/lib/src/serialization/strategies.dart", "new_id": "b7017e139c40f1ae20cb063209bfa4671aacf99a", "new_mode": 33188, "new_path": "pkg/compiler/lib/src/serialization/strategies.dart" }, { "type": "modify", "old_id": "e6ba8181de010ec9f36b95e3c66c8bd968c76c6e", "old_mode": 33188, "old_path": "pkg/compiler/lib/src/serialization/task.dart", "new_id": "a5de3dd538b964c208f40f92e835bf6230bec8af", "new_mode": 33188, "new_path": "pkg/compiler/lib/src/serialization/task.dart" }, { "type": "modify", "old_id": "4b0279679dd0e1df22802e4133dd723e41d6f9c6", "old_mode": 33188, "old_path": "pkg/compiler/lib/src/util/diagnostic_helper.dart", "new_id": "022314b611a531662221f3010dc0d6ec683e1881", "new_mode": 33188, "new_path": "pkg/compiler/lib/src/util/diagnostic_helper.dart" }, { "type": "modify", "old_id": "d34de0a07e3ca44792514e1d0bd46b53d36717df", "old_mode": 33188, "old_path": "pkg/compiler/lib/src/util/memory_compiler.dart", "new_id": "cadba4bf12cf60da12840a82d0d35fe6679e1aef", "new_mode": 33188, "new_path": "pkg/compiler/lib/src/util/memory_compiler.dart" }, { "type": "modify", "old_id": "7b169dce338ec17e010c9829168e08684ed680f7", "old_mode": 33188, "old_path": "pkg/compiler/test/analyses/analysis_helper.dart", "new_id": "19b1fe0f3176a16f395db8d6d44613963ccda096", "new_mode": 33188, "new_path": "pkg/compiler/test/analyses/analysis_helper.dart" }, { "type": "modify", "old_id": "98cdc3a08bca4bc6a5db2fd89b21e600c48206b9", "old_mode": 33188, "old_path": "pkg/compiler/test/model/cfe_constant_evaluation_test.dart", "new_id": "3dccc8d5a17ac9a52e67a19939968046f19edb09", "new_mode": 33188, "new_path": "pkg/compiler/test/model/cfe_constant_evaluation_test.dart" }, { "type": "modify", "old_id": "062a6fab3d7514ca2c9772e8ff9d70ab72f2445f", "old_mode": 33188, "old_path": "pkg/compiler/test/serialization/serialization_test_helper.dart", "new_id": "ddb3513b2c11f160e3f4a8f61f4850e4c7fcd3c8", "new_mode": 33188, "new_path": "pkg/compiler/test/serialization/serialization_test_helper.dart" } ] }