| commit | d7e6e0e8c3fbd871cc9dd5a6cfc1718067d93c94 | [log] [tgz] |
|---|---|---|
| author | Tess Strickland <sstrickl@google.com> | Thu Jun 06 09:14:18 2024 +0000 |
| committer | Commit Queue <dart-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Jun 06 09:14:18 2024 +0000 |
| tree | 035725e71ebc6ef757204575cd50a4e43098524a | |
| parent | d91f05c1c7d2d5f8ffe388a8a087a06e009977a0 [diff] |
[vm/compiler] Fix dart fuzzer CalculateElementAddress crash on X64C. In the backend, handle the following cases that were assumed not to happen before: * If the index and offset are both 0, then the operation is a no-op and so the output register should be the same as the first input. (Should only happen if the instruction is used in a non-optimizing context, as otherwise it is removed by canonicalization.) * If the scaled index can be used as an instruction immediate and the offset is 0, then emit the appropriate instruction(s). * If the scaled index and offset can both be used as immediates to instructions, but their sum (the total offset in bytes) cannot, then allocate a register for the index and fall back to the non-constant index case. CalculateElementAddress::Canonicalize now only performs removal of no-op instructions. This CL also fixes a switch on the instruction tag in FlowGraph::RenameRecursive to appropriately convert UnboxedConstant instructions to initial definitions of the FlowGraph as it already does for Constant instructions. TEST=vm/dart/regress_55877 Issue: https://github.com/dart-lang/sdk/issues/55877 Cq-Include-Trybots: luci.dart.try:vm-aot-linux-debug-simarm_x64-try,vm-aot-linux-debug-simriscv64-try,vm-aot-linux-debug-x64-try,vm-aot-linux-debug-x64c-try,vm-linux-debug-ia32-try,vm-linux-debug-x64-try,vm-linux-debug-x64c-try,vm-linux-debug-simriscv64-try,vm-mac-debug-arm64-try,vm-aot-mac-release-arm64-try Change-Id: I613d6c8770fe02facf6bbdb3d2b11f842b51540d Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/369642 Commit-Queue: Tess Strickland <sstrickl@google.com> Reviewed-by: Ryan Macnak <rmacnak@google.com>
Dart is:
Approachable: Develop with a strongly typed programming language that is consistent, concise, and offers modern language features like null safety and patterns.
Portable: Compile to ARM, x64, or RISC-V machine code for mobile, desktop, and backend. Compile to JavaScript or WebAssembly for the web.
Productive: Make changes iteratively: use hot reload to see the result instantly in your running app. Diagnose app issues using DevTools.
Dart's flexible compiler technology lets you run Dart code in different ways, depending on your target platform and goals:
Dart Native: For programs targeting devices (mobile, desktop, server, and more), Dart Native includes both a Dart VM with JIT (just-in-time) compilation and an AOT (ahead-of-time) compiler for producing machine code.
Dart Web: For programs targeting the web, Dart Web includes both a development time compiler (dartdevc) and a production time compiler (dart2js).
Dart is free and open source.
See LICENSE and PATENT_GRANT.
Visit dart.dev to learn more about the language, tools, and to find codelabs.
Browse pub.dev for more packages and libraries contributed by the community and the Dart team.
Our API reference documentation is published at api.dart.dev, based on the stable release. (We also publish docs from our beta and dev channels, as well as from the primary development branch).
If you want to build Dart yourself, here is a guide to getting the source, preparing your machine to build the SDK, and building.
There are more documents in our repo at docs.
The easiest way to contribute to Dart is to file issues.
You can also contribute patches, as described in Contributing.
Future plans for Dart are included in the combined Dart and Flutter roadmap on the Flutter wiki.