Google Git
Sign in
dart / sdk / d3c06c4822fba382aab659a2d6905e316ebb420c
commitd3c06c4822fba382aab659a2d6905e316ebb420c[log] [tgz]
authorDanny Tuppeny <danny@tuppeny.com>Mon Jun 03 15:45:56 2024 +0000
committerCommit Queue <dart-scoped@luci-project-accounts.iam.gserviceaccount.com>Mon Jun 03 15:45:56 2024 +0000
treebfae52f4af801d580cc99b268eb82cf22e5910fa
parent92fcb8d21cc093bc7c39ba0bbe980e63bd21184d [diff]
[analysis_server] Fix handling of semantic tokens when roots are being built

This fixes https://github.com/dart-lang/sdk/issues/55889 which is repeat of https://github.com/Dart-Code/Dart-Code/issues/3929 (but semantic tokens was not fixed with that CL).

The issue was when the server was initialized with no roots (for example an empty workspace) and then a new file opened with requests being sent immediately before the roots were updated.

The fix changes from directly calling `server.getResolvedUnit` to instead using `requireResolvedUnit` which handles this situation by waiting for any in-progress context changes and retries.

Fixes https://github.com/dart-lang/sdk/issues/55889

Change-Id: Id078947e5c6665b2afb9e31adc244f16987870f0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/369464
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
2 files changed
tree: bfae52f4af801d580cc99b268eb82cf22e5910fa
  1. .dart_tool/
  2. .github/
  3. benchmarks/
  4. build/
  5. docs/
  6. pkg/
  7. runtime/
  8. samples/
  9. sdk/
  10. tests/
  11. third_party/
  12. tools/
  13. utils/
  14. .clang-format
  15. .gitattributes
  16. .gitconfig
  17. .gitignore
  18. .gn
  19. .mailmap
  20. .style.yapf
  21. AUTHORS
  22. BUILD.gn
  23. CHANGELOG.md
  24. codereview.settings
  25. CONTRIBUTING.md
  26. DEPS
  27. LICENSE
  28. OWNERS
  29. PATENT_GRANT
  30. PRESUBMIT.py
  31. README.dart-sdk
  32. README.md
  33. sdk.code-workspace
  34. sdk_args.gni
  35. sdk_packages.yaml
  36. SECURITY.md
  37. WATCHLISTS
README.md

Dart

An approachable, portable, and productive language for high-quality apps on any platform

Dart is:

  • Approachable: Develop with a strongly typed programming language that is consistent, concise, and offers modern language features like null safety and patterns.

  • Portable: Compile to ARM, x64, or RISC-V machine code for mobile, desktop, and backend. Compile to JavaScript or WebAssembly for the web.

  • Productive: Make changes iteratively: use hot reload to see the result instantly in your running app. Diagnose app issues using DevTools.

Dart's flexible compiler technology lets you run Dart code in different ways, depending on your target platform and goals:

  • Dart Native: For programs targeting devices (mobile, desktop, server, and more), Dart Native includes both a Dart VM with JIT (just-in-time) compilation and an AOT (ahead-of-time) compiler for producing machine code.

  • Dart Web: For programs targeting the web, Dart Web includes both a development time compiler (dartdevc) and a production time compiler (dart2js).

Dart platforms illustration

License & patents

Dart is free and open source.

See LICENSE and PATENT_GRANT.

Using Dart

Visit dart.dev to learn more about the language, tools, and to find codelabs.

Browse pub.dev for more packages and libraries contributed by the community and the Dart team.

Our API reference documentation is published at api.dart.dev, based on the stable release. (We also publish docs from our beta and dev channels, as well as from the primary development branch).

Building Dart

If you want to build Dart yourself, here is a guide to getting the source, preparing your machine to build the SDK, and building.

There are more documents in our repo at docs.

Contributing to Dart

The easiest way to contribute to Dart is to file issues.

You can also contribute patches, as described in Contributing.

Roadmap

Future plans for Dart are included in the combined Dart and Flutter roadmap on the Flutter wiki.