commit d12904f27832e4feae9df1cbe33c43f0dbf5953f
author Alexander Thomas <athom@google.com> Wed Aug 30 14:13:37 2023 +0000
committer Commit Queue <dart-scoped@luci-project-accounts.iam.gserviceaccount.com> Wed Aug 30 14:13:37 2023 +0000
tree 939cef877bf7b186de98d1313bd19baf84af351d
parent e2971da5632ceaaec4e7276ac8d4efa753a41aee

[dds] Fix sse_smoke_test on Windows

Cq-Include-Trybots: luci.dart.try:pkg-win-release-try
Change-Id: I8993ee16a23bfbaeffaf48f6ef5906a4e90f11fe
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/322703
Auto-Submit: Alexander Thomas <athom@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>

pkg/dds/test/sse_smoke_test.dart

diff --git a/pkg/dds/test/sse_smoke_test.dart b/pkg/dds/test/sse_smoke_test.dart
index 6d49e9f..0bafa43 100644
--- a/pkg/dds/test/sse_smoke_test.dart
+++ b/pkg/dds/test/sse_smoke_test.dart
@@ -29,10 +29,14 @@
   late WebDriver webdriver;
 
   setUpAll(() async {
-    final chromedriverUri = Platform.script.resolveUri(
-        Uri.parse('../../../third_party/webdriver/chrome/chromedriver'));
+    var chromedriverPath = '../../../third_party/webdriver/chrome/chromedriver';
+    if (Platform.isWindows) {
+      chromedriverPath = '$chromedriverPath.exe';
+    }
+    final chromedriverUri =
+        Platform.script.resolveUri(Uri.parse(chromedriverPath));
     try {
-      chromeDriver = await Process.start(chromedriverUri.path, [
+      chromeDriver = await Process.start(chromedriverUri.toFilePath(), [
         '--port=4444',
         '--url-base=wd/hub',
       ]);
@@ -54,7 +58,7 @@
       final cascade = shelf.Cascade()
           .add(handler.handler)
           .add(_faviconHandler)
-          .add(createStaticHandler(Platform.script.resolve('web').path,
+          .add(createStaticHandler(Platform.script.resolve('web').toFilePath(),
               listDirectories: true, defaultDocument: 'index.html'));
 
       server = await io.serve(cascade.handler, 'localhost', 0);