Google Git
Sign in
dart / sdk / eafb6b73f7ddab69d7832f20fc7e336d62bcca48
commiteafb6b73f7ddab69d7832f20fc7e336d62bcca48[log] [tgz]
authorNate Biggs <natebiggs@google.com>Fri Oct 25 14:57:39 2024 +0000
committerCommit Queue <dart-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Oct 25 14:57:39 2024 +0000
treebf3a132ffeab159fe39ff8931a8742b897ee3ee7
parentd4fdb846d6824cfd6b678ad33ec31dffcd24f66c [diff]
[dart2wasm] Fix dispatch table class ID loop bounds.

The loop iterates over the class IDs up to (but not including) maxConcreteClassId. But maxConcreteClassId is the actual ID of the last concrete class so the loop is ending 1 early.

From some testing, WasmTable seems to always be the last class. This class doesn't have any subclasses so all the calls to it are likely devirtualized anyway skipping the dispatch table. In fact the way the class IDs are assigned, the last class should always be a leaf concrete class. I believe that's why this hasn't caused a detectable bug.

Change-Id: I7003dfd015c2ad13a4a042ae86af5e4f54242452
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/391862
Commit-Queue: Nate Biggs <natebiggs@google.com>
Reviewed-by: Ömer Ağacan <omersa@google.com>
1 file changed
tree: bf3a132ffeab159fe39ff8931a8742b897ee3ee7
  1. .dart_tool/
  2. .github/
  3. benchmarks/
  4. build/
  5. docs/
  6. pkg/
  7. runtime/
  8. samples/
  9. sdk/
  10. tests/
  11. third_party/
  12. tools/
  13. utils/
  14. .clang-format
  15. .gitattributes
  16. .gitconfig
  17. .gitignore
  18. .gn
  19. .mailmap
  20. .style.yapf
  21. AUTHORS
  22. BUILD.gn
  23. CHANGELOG.md
  24. codereview.settings
  25. CONTRIBUTING.md
  26. DEPS
  27. LICENSE
  28. OWNERS
  29. PATENT_GRANT
  30. PRESUBMIT.py
  31. README.dart-sdk
  32. README.md
  33. sdk.code-workspace
  34. sdk_args.gni
  35. sdk_packages.yaml
  36. SECURITY.md
  37. WATCHLISTS
README.md

Dart

An approachable, portable, and productive language for high-quality apps on any platform

Dart is:

  • Approachable: Develop with a strongly typed programming language that is consistent, concise, and offers modern language features like null safety and patterns.

  • Portable: Compile to ARM, x64, or RISC-V machine code for mobile, desktop, and backend. Compile to JavaScript or WebAssembly for the web.

  • Productive: Make changes iteratively: use hot reload to see the result instantly in your running app. Diagnose app issues using DevTools.

Dart's flexible compiler technology lets you run Dart code in different ways, depending on your target platform and goals:

  • Dart Native: For programs targeting devices (mobile, desktop, server, and more), Dart Native includes both a Dart VM with JIT (just-in-time) compilation and an AOT (ahead-of-time) compiler for producing machine code.

  • Dart Web: For programs targeting the web, Dart Web includes both a development time compiler (dartdevc) and a production time compiler (dart2js).

Dart platforms illustration

License & patents

Dart is free and open source.

See LICENSE and PATENT_GRANT.

Using Dart

Visit dart.dev to learn more about the language, tools, and to find codelabs.

Browse pub.dev for more packages and libraries contributed by the community and the Dart team.

Our API reference documentation is published at api.dart.dev, based on the stable release. (We also publish docs from our beta and dev channels, as well as from the primary development branch).

Building Dart

If you want to build Dart yourself, here is a guide to getting the source, preparing your machine to build the SDK, and building.

There are more documents in our repo at docs.

Contributing to Dart

The easiest way to contribute to Dart is to file issues.

You can also contribute patches, as described in Contributing.

Roadmap

Future plans for Dart are included in the combined Dart and Flutter roadmap on the Flutter wiki.