)]}' { "commit": "cddc2d42e1488e921d649b58d47fbf4c874306dc", "tree": "b1791497a0d27221f8c911b6f3fbf39890fb8c48", "parents": [ "8b6f8969a6d3367a6ad2551c290048c61941ef77" ], "author": { "name": "Danny Tuppeny", "email": "dantup@google.com", "time": "Mon Oct 22 14:40:54 2018 +0000" }, "committer": { "name": "commit-bot@chromium.org", "email": "commit-bot@chromium.org", "time": "Mon Oct 22 14:40:54 2018 +0000" }, "message": "Handle generic types in LSP spec parsing\n\nThe regex wasn\u0027t picking up generate type args (in interface definitions or usages in field definitions). This adds \u003c\u003e characters to the regex and handles them in mapping of types (as well as adds some additional tests to cover this).\n\nChange-Id: I8187b3d2abb2b35c0d7638839e3116700cfbf9e0\nReviewed-on: https://dart-review.googlesource.com/c/81004\nReviewed-by: Brian Wilkerson \u003cbrianwilkerson@google.com\u003e\nCommit-Queue: Danny Tuppeny \u003cdantup@google.com\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "1c328104067f2626a9a00c787668b1f14fee0dde", "old_mode": 33188, "old_path": "pkg/analysis_server/lib/lsp_protocol/protocol_generated.dart", "new_id": "d6fb0e54407c7adbc7340036ddb9a9113e8a59fc", "new_mode": 33188, "new_path": "pkg/analysis_server/lib/lsp_protocol/protocol_generated.dart" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "068063cc3706c5676a0fed5f3f5d3185bb66c6d4", "new_mode": 33188, "new_path": "pkg/analysis_server/test/tool/lsp_spec/dart_test.dart" }, { "type": "modify", "old_id": "646d49a7ddd5b881d300fd19c103b9f551da4b88", "old_mode": 33188, "old_path": "pkg/analysis_server/test/tool/lsp_spec/json_test.dart", "new_id": "bc07300aed3a4a871341f6e463e8c0ce86786deb", "new_mode": 33188, "new_path": "pkg/analysis_server/test/tool/lsp_spec/json_test.dart" }, { "type": "modify", "old_id": "77e3be753d745c633a05226777bdefcfbad44764", "old_mode": 33188, "old_path": "pkg/analysis_server/test/tool/lsp_spec/typescript_test.dart", "new_id": "1fad598c6a490888490cdb488091060c605d2125", "new_mode": 33188, "new_path": "pkg/analysis_server/test/tool/lsp_spec/typescript_test.dart" }, { "type": "modify", "old_id": "1f96c6472d2fc215786a2103cb47e957ecf1b431", "old_mode": 33188, "old_path": "pkg/analysis_server/tool/lsp_spec/codegen_dart.dart", "new_id": "54b0ee1c13ec8933c004425decec03c7cb5873f1", "new_mode": 33188, "new_path": "pkg/analysis_server/tool/lsp_spec/codegen_dart.dart" }, { "type": "modify", "old_id": "286b0e276bbd15c52283919e826fa998be629e2f", "old_mode": 33188, "old_path": "pkg/analysis_server/tool/lsp_spec/typescript.dart", "new_id": "017c666b836c2485f3941668423e483e42588d9d", "new_mode": 33188, "new_path": "pkg/analysis_server/tool/lsp_spec/typescript.dart" } ] }