commit | cc61a433cef83ae9589ec0aa25c8cde182ba941e | [log] [tgz] |
---|---|---|
author | Konstantin Shcheglov <scheglov@google.com> | Thu Aug 28 13:48:49 2025 -0700 |
committer | Commit Queue <dart-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Aug 28 13:48:49 2025 -0700 |
tree | c6cd396d444b03e91b118d498ad929a953597be8 | |
parent | c8869151bd226aa938760508c0da9b732c0770b3 [diff] |
Elements. Infer type arguments for redirected generic factory constructors. Fix element model building to infer type arguments for redirected factory constructors of generic classes (both named and unnamed). This brings element construction in line with AST resolution so redirected targets carry the correct type substitutions instead of defaulting to uninstantiated or incorrect types. What changed: - Perform generic inference when resolving the redirect target type in `NamedTypeResolver`, using the enclosing class as context. - Replace the brittle `redirectedConstructor_namedType` tracking with structural detection of redirecting constructor contexts. - Ensure `ResolutionVisitor` provides the enclosing class to the type resolver and visit the redirection directly. - Adjust `AstResolver` ordering so enclosing declaration info is set before resolving constructor children. - Bump `DATA_VERSION` to invalidate stale serialized data. Why: - Previously, only AST resolution performed inference. Element model building skipped it, producing incorrect constructor redirections in summaries and downstream analyses. Aligning both paths fixes those inconsistencies. Impact: - Correct substitutions are recorded for redirected constructors in summaries; no public API changes expected. - Adds targeted tests to prevent regressions (no behavioral changes beyond the intended inference fix). Fixes: flutter/flutter#174503 Bug: https://github.com/flutter/flutter/issues/174503 Change-Id: If231de40de9af15ec14dc26cda28bdc269d9896e Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/447603 Commit-Queue: Konstantin Shcheglov <scheglov@google.com> Reviewed-by: Paul Berry <paulberry@google.com>
Dart is:
Approachable: Develop with a strongly typed programming language that is consistent, concise, and offers modern language features like null safety and patterns.
Portable: Compile to ARM, x64, or RISC-V machine code for mobile, desktop, and backend. Compile to JavaScript or WebAssembly for the web.
Productive: Make changes iteratively: use hot reload to see the result instantly in your running app. Diagnose app issues using DevTools.
Dart's flexible compiler technology lets you run Dart code in different ways, depending on your target platform and goals:
Dart Native: For programs targeting devices (mobile, desktop, server, and more), Dart Native includes both a Dart VM with JIT (just-in-time) compilation and an AOT (ahead-of-time) compiler for producing machine code.
Dart Web: For programs targeting the web, Dart Web includes both a development time compiler (dartdevc) and a production time compiler (dart2js).
Dart is free and open source.
See LICENSE and PATENT_GRANT.
Visit dart.dev to learn more about the language, tools, and to find codelabs.
Browse pub.dev for more packages and libraries contributed by the community and the Dart team.
Our API reference documentation is published at api.dart.dev, based on the stable release. (We also publish docs from our beta and dev channels, as well as from the primary development branch).
If you want to build Dart yourself, here is a guide to getting the source, preparing your machine to build the SDK, and building.
There are more documents in our repo at docs.
The easiest way to contribute to Dart is to file issues.
You can also contribute patches, as described in Contributing.
Future plans for Dart are included in the combined Dart and Flutter roadmap on the Flutter wiki.