analyzer: Use a consistent case in warning names
There is only one written in lower_snake_case. Rename it so that
every warning is written in SCREAMING_SNAKE_CASE.
Change-Id: If1db2c772899ff3cde25736dc2423d141d0f49ee
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/425156
Auto-Submit: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
diff --git a/pkg/analysis_server/lib/src/services/correction/error_fix_status.yaml b/pkg/analysis_server/lib/src/services/correction/error_fix_status.yaml
index f5dd1da..13be67d 100644
--- a/pkg/analysis_server/lib/src/services/correction/error_fix_status.yaml
+++ b/pkg/analysis_server/lib/src/services/correction/error_fix_status.yaml
@@ -3624,7 +3624,7 @@
status: hasFix
WarningCode.INVALID_REQUIRED_POSITIONAL_PARAM:
status: hasFix
-WarningCode.invalid_use_of_do_not_submit_member:
+WarningCode.INVALID_USE_OF_DO_NOT_SUBMIT_MEMBER:
status: needsEvaluation
WarningCode.INVALID_USE_OF_INTERNAL_MEMBER:
status: noFix
diff --git a/pkg/analyzer/lib/src/error/best_practices_verifier.dart b/pkg/analyzer/lib/src/error/best_practices_verifier.dart
index 71cc548..8ac7187 100644
--- a/pkg/analyzer/lib/src/error/best_practices_verifier.dart
+++ b/pkg/analyzer/lib/src/error/best_practices_verifier.dart
@@ -1852,7 +1852,7 @@
_errorReporter.atOffset(
offset: errorEntity.offset,
length: errorEntity.length,
- errorCode: WarningCode.invalid_use_of_do_not_submit_member,
+ errorCode: WarningCode.INVALID_USE_OF_DO_NOT_SUBMIT_MEMBER,
arguments: [name],
);
}
@@ -1897,14 +1897,14 @@
_errorReporter.atOffset(
offset: errorEntity.offset,
length: errorEntity.length,
- errorCode: WarningCode.invalid_use_of_do_not_submit_member,
+ errorCode: WarningCode.INVALID_USE_OF_DO_NOT_SUBMIT_MEMBER,
arguments: [name],
);
} else {
// For positional arguments.
_errorReporter.atNode(
argument,
- WarningCode.invalid_use_of_do_not_submit_member,
+ WarningCode.INVALID_USE_OF_DO_NOT_SUBMIT_MEMBER,
arguments: [element.displayName],
);
}
diff --git a/pkg/analyzer/lib/src/error/codes.g.dart b/pkg/analyzer/lib/src/error/codes.g.dart
index d6cf9e5..bd239e8 100644
--- a/pkg/analyzer/lib/src/error/codes.g.dart
+++ b/pkg/analyzer/lib/src/error/codes.g.dart
@@ -6888,6 +6888,15 @@
/// Parameters:
/// 0: the name of the member
+ static const WarningCode INVALID_USE_OF_DO_NOT_SUBMIT_MEMBER = WarningCode(
+ 'INVALID_USE_OF_DO_NOT_SUBMIT_MEMBER',
+ "Uses of '{0}' should not be submitted to source control.",
+ correctionMessage: "Try removing the reference to '{0}'.",
+ hasPublishedDocs: true,
+ );
+
+ /// Parameters:
+ /// 0: the name of the member
static const WarningCode INVALID_USE_OF_INTERNAL_MEMBER = WarningCode(
'INVALID_USE_OF_INTERNAL_MEMBER',
"The member '{0}' can only be used within its package.",
@@ -7737,15 +7746,6 @@
hasPublishedDocs: true,
);
- /// Parameters:
- /// 0: the name of the member
- static const WarningCode invalid_use_of_do_not_submit_member = WarningCode(
- 'invalid_use_of_do_not_submit_member',
- "Uses of '{0}' should not be submitted to source control.",
- correctionMessage: "Try removing the reference to '{0}'.",
- hasPublishedDocs: true,
- );
-
/// Initialize a newly created error code to have the given [name].
const WarningCode(
String name,
diff --git a/pkg/analyzer/lib/src/error/error_code_values.g.dart b/pkg/analyzer/lib/src/error/error_code_values.g.dart
index f668306..c7fd120 100644
--- a/pkg/analyzer/lib/src/error/error_code_values.g.dart
+++ b/pkg/analyzer/lib/src/error/error_code_values.g.dart
@@ -1039,6 +1039,7 @@
WarningCode.INVALID_REQUIRED_NAMED_PARAM,
WarningCode.INVALID_REQUIRED_OPTIONAL_POSITIONAL_PARAM,
WarningCode.INVALID_REQUIRED_POSITIONAL_PARAM,
+ WarningCode.INVALID_USE_OF_DO_NOT_SUBMIT_MEMBER,
WarningCode.INVALID_USE_OF_INTERNAL_MEMBER,
WarningCode.INVALID_USE_OF_PROTECTED_MEMBER,
WarningCode.INVALID_USE_OF_VISIBLE_FOR_OVERRIDING_MEMBER,
@@ -1119,5 +1120,4 @@
WarningCode.UNUSED_RESULT_WITH_MESSAGE,
WarningCode.UNUSED_SHOWN_NAME,
WarningCode.URI_DOES_NOT_EXIST_IN_DOC_IMPORT,
- WarningCode.invalid_use_of_do_not_submit_member,
];
diff --git a/pkg/analyzer/messages.yaml b/pkg/analyzer/messages.yaml
index 2c4ad52..e2824dd 100644
--- a/pkg/analyzer/messages.yaml
+++ b/pkg/analyzer/messages.yaml
@@ -24742,7 +24742,7 @@
Parameters:
0: the name of the member
- invalid_use_of_do_not_submit_member:
+ INVALID_USE_OF_DO_NOT_SUBMIT_MEMBER:
problemMessage: "Uses of '{0}' should not be submitted to source control."
correctionMessage: "Try removing the reference to '{0}'."
hasPublishedDocs: true
diff --git a/pkg/analyzer/test/src/diagnostics/invalid_do_not_submit_test.dart b/pkg/analyzer/test/src/diagnostics/invalid_do_not_submit_test.dart
index 73fbf2d..333f5bb 100644
--- a/pkg/analyzer/test/src/diagnostics/invalid_do_not_submit_test.dart
+++ b/pkg/analyzer/test/src/diagnostics/invalid_do_not_submit_test.dart
@@ -44,7 +44,7 @@
await assertErrorsInFile2(a, []);
await assertErrorsInFile2(b, [
- error(WarningCode.invalid_use_of_do_not_submit_member, 31, 1),
+ error(WarningCode.INVALID_USE_OF_DO_NOT_SUBMIT_MEMBER, 31, 1),
]);
}
@@ -69,7 +69,7 @@
await assertErrorsInFile2(a, []);
await assertErrorsInFile2(b, [
- error(WarningCode.invalid_use_of_do_not_submit_member, 31, 1),
+ error(WarningCode.INVALID_USE_OF_DO_NOT_SUBMIT_MEMBER, 31, 1),
]);
}
@@ -169,7 +169,7 @@
await assertErrorsInFile2(a, []);
await assertErrorsInFile2(b, [
- error(WarningCode.invalid_use_of_do_not_submit_member, 39, 1),
+ error(WarningCode.INVALID_USE_OF_DO_NOT_SUBMIT_MEMBER, 39, 1),
]);
}
@@ -193,7 +193,7 @@
await assertErrorsInFile2(a, []);
await assertErrorsInFile2(b, [
- error(WarningCode.invalid_use_of_do_not_submit_member, 33, 1),
+ error(WarningCode.INVALID_USE_OF_DO_NOT_SUBMIT_MEMBER, 33, 1),
]);
}
@@ -217,7 +217,7 @@
await assertErrorsInFile2(a, []);
await assertErrorsInFile2(b, [
- error(WarningCode.invalid_use_of_do_not_submit_member, 33, 1),
+ error(WarningCode.INVALID_USE_OF_DO_NOT_SUBMIT_MEMBER, 33, 1),
]);
}
@@ -237,7 +237,7 @@
await assertErrorsInFile2(a, []);
await assertErrorsInFile2(b, [
- error(WarningCode.invalid_use_of_do_not_submit_member, 30, 1),
+ error(WarningCode.INVALID_USE_OF_DO_NOT_SUBMIT_MEMBER, 30, 1),
]);
}
@@ -262,7 +262,7 @@
await assertErrorsInFile2(a, []);
await assertErrorsInFile2(b, [
- error(WarningCode.invalid_use_of_do_not_submit_member, 54, 1),
+ error(WarningCode.INVALID_USE_OF_DO_NOT_SUBMIT_MEMBER, 54, 1),
]);
}
@@ -309,7 +309,7 @@
await assertErrorsInFile2(a, []);
await assertErrorsInFile2(b, [
- error(WarningCode.invalid_use_of_do_not_submit_member, 48, 1),
+ error(WarningCode.INVALID_USE_OF_DO_NOT_SUBMIT_MEMBER, 48, 1),
]);
}
@@ -330,7 +330,7 @@
await assertErrorsInFile2(a, []);
await assertErrorsInFile2(b, [
- error(WarningCode.invalid_use_of_do_not_submit_member, 33, 1),
+ error(WarningCode.INVALID_USE_OF_DO_NOT_SUBMIT_MEMBER, 33, 1),
]);
}
@@ -351,7 +351,7 @@
await assertErrorsInFile2(a, []);
await assertErrorsInFile2(b, [
- error(WarningCode.invalid_use_of_do_not_submit_member, 33, 1),
+ error(WarningCode.INVALID_USE_OF_DO_NOT_SUBMIT_MEMBER, 33, 1),
]);
}
@@ -366,7 +366,7 @@
''');
await assertErrorsInFile2(a, [
- error(WarningCode.invalid_use_of_do_not_submit_member, 72, 1),
+ error(WarningCode.INVALID_USE_OF_DO_NOT_SUBMIT_MEMBER, 72, 1),
]);
}
@@ -391,7 +391,7 @@
await assertErrorsInFile2(a, []);
await assertErrorsInFile2(b, [
- error(WarningCode.invalid_use_of_do_not_submit_member, 48, 1),
+ error(WarningCode.INVALID_USE_OF_DO_NOT_SUBMIT_MEMBER, 48, 1),
]);
}
@@ -411,7 +411,7 @@
await assertErrorsInFile2(a, []);
await assertErrorsInFile2(b, [
- error(WarningCode.invalid_use_of_do_not_submit_member, 36, 1),
+ error(WarningCode.INVALID_USE_OF_DO_NOT_SUBMIT_MEMBER, 36, 1),
]);
}
}
