Fix #34443 fix tests that will fail with int2double
Bug: 34443
Change-Id: I2b0edb9f6f1e642c92a656301f9b8a85c3e4658c
Reviewed-on: https://dart-review.googlesource.com/74669
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
diff --git a/tests/language_2/const_constructor3_test.dart b/tests/language_2/const_constructor3_test.dart
index e8aac19..e12c4b7 100644
--- a/tests/language_2/const_constructor3_test.dart
+++ b/tests/language_2/const_constructor3_test.dart
@@ -11,10 +11,11 @@
const D(var d) : super(d);
}
+const intValue = 0;
const c = const C(0.0); //# 01: ok
-const d = const C(0); //# 02: compile-time error
+const d = const C(intValue); //# 02: compile-time error
const e = const D(0.0); //# 03: ok
-const f = const D(0); //# 04: compile-time error
+const f = const D(intValue); //# 04: compile-time error
main() {
print(c); //# 01: continued
diff --git a/tests/language_2/const_init2_test.dart b/tests/language_2/const_init2_test.dart
index d45c5d5..fcc6f6f 100644
--- a/tests/language_2/const_init2_test.dart
+++ b/tests/language_2/const_init2_test.dart
@@ -2,8 +2,9 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
+const intValue = 0;
const double c = 0.0; //# 01: ok
-const double d = 0; //# 02: compile-time error
+const double d = intValue; //# 02: compile-time error
main() {
print(c); //# 01: continued
diff --git a/tests/language_2/language_2_analyzer.status b/tests/language_2/language_2_analyzer.status
index 299bdcd..d3ddd0c 100644
--- a/tests/language_2/language_2_analyzer.status
+++ b/tests/language_2/language_2_analyzer.status
@@ -19,9 +19,7 @@
conflicting_generic_interfaces_hierarchy_loop_infinite_test: Skip # Issue #34333 (loops forever)
const_cast2_test/01: CompileTimeError # failing-by-design: Not a const expression, see Issue #34334
const_cast2_test/none: CompileTimeError # failing-by-design: Not a const expression, see Issue #34334
-const_constructor3_test/02: MissingCompileTimeError # Needs triage, see Issue #34443
const_constructor3_test/04: MissingCompileTimeError # Side-effect of working around issue 33441 for int-to-double
-const_init2_test/02: MissingCompileTimeError # Needs triage, see Issue #34443
constructor_reference_test/27: MissingCompileTimeError # Issue 34403
covariant_subtyping_with_mixin_test: CompileTimeError # Issue 34329
default_implementation2_test: CompileTimeError # Issue #34338, however, needs triage (#34337) and blocked (#34336)
diff --git a/tests/language_2/language_2_dartdevc.status b/tests/language_2/language_2_dartdevc.status
index 4c23494..cd32a21 100644
--- a/tests/language_2/language_2_dartdevc.status
+++ b/tests/language_2/language_2_dartdevc.status
@@ -32,11 +32,9 @@
conflicting_generic_interfaces_simple_test: MissingCompileTimeError
const_cast2_test/01: CompileTimeError
const_cast2_test/none: CompileTimeError
-const_constructor3_test/02: MissingCompileTimeError # Needs triage, see Issue #34443
const_constructor3_test/04: MissingCompileTimeError # Side-effect of working around issue 33441 for int-to-double
const_constructor_mixin3_test/01: MissingCompileTimeError # Issue 33644
const_constructor_mixin_test/01: MissingCompileTimeError # Issue 33644
-const_init2_test/02: MissingCompileTimeError # Needs triage, see Issue #34443
constructor_reference_test/27: MissingCompileTimeError # Issue https://github.com/dart-lang/sdk/issues/34403
covariance_field_test/03: RuntimeError
covariant_override/tear_off_type_test: RuntimeError # Issue 28395
