)]}'
{
  "commit": "ca16a4271cbb9bec2da06aa2bf95b70c9f7b3953",
  "tree": "bf53fec04bd7ceb1aa939ee3fdb37fce90e4b832",
  "parents": [
    "49a9d42cfc08138b3d230296d704ae99c4ae1323"
  ],
  "author": {
    "name": "Jens Johansen",
    "email": "jensj@google.com",
    "time": "Wed Feb 05 03:12:26 2025 -0800"
  },
  "committer": {
    "name": "Commit Queue",
    "email": "dart-scoped@luci-project-accounts.iam.gserviceaccount.com",
    "time": "Wed Feb 05 03:12:26 2025 -0800"
  },
  "message": "[scanner] Replace KeywordState\n\nAs bechmarked with the AOT compiles of `scanner_benchmark.dart`\ncalled with\n`pkg/_fe_analyzer_shared/lib/src/parser/parser_impl.dart --bytes`:\n\n```\n    N           Min           Max        Median           Avg        Stddev\nx  25     138.56434     144.23326     142.64174     142.51626     1.2207074\n+  25     148.45681     157.02163     156.44878     155.88958     1.7051997\nDifference at 95.0% confidence\n        13.3733 +/- 0.843454\n        9.38372% +/- 0.59183%\n        (Student\u0027s t, pooled s \u003d 1.48287)\n```\n\nAnd compiling the CFE from December with the CFE, statistics on 25 runs\neach, run with `--cache --silent` (so 2 x 50 runs each) (in AOT mode):\n\n```\nmsec task-clock:u: -0.9684% +/- 0.3536% (-58.65 +/- 21.42)\npage-faults:u: -0.1051% +/- 0.0818% (-125.36 +/- 97.49)\ncycles:u: -1.0001% +/- 0.3225% (-252905081.28 +/- 81554799.59)\ninstructions:u: -0.5915% +/- 0.0007% (-181426590.44 +/- 209346.28)\nseconds time elapsed: -0.9657% +/- 0.3525% (-0.06 +/- 0.02)\nseconds user: -1.1336% +/- 0.4333% (-0.07 +/- 0.03)\n\nmsec task-clock:u: -1.3115% +/- 0.3364% (-79.48 +/- 20.39)\npage-faults:u: -0.1900% +/- 0.0774% (-226.72 +/- 92.37)\nL1-icache-load-misses: 0.4990% +/- 0.2072% (2422435.64 +/- 1006075.94)\nLLC-loads: -2.3896% +/- 0.1707% (-1179245.64 +/- 84228.28)\nLLC-load-misses: -1.9244% +/- 0.2041% (-639169.84 +/- 67791.64)\nseconds time elapsed: -1.3128% +/- 0.3374% (-0.08 +/- 0.02)\nseconds user: -1.3311% +/- 0.4183% (-0.08 +/- 0.02)\n```\n\nCombined the 3 CLs ending here gives this result when compiling\nthe CFE from December with the CFE, statistics on 25 runs each,\nrun with `--cache --silent` (so 2 x 50 runs each) (in AOT mode):\n\n```\nmsec task-clock:u: -1.7681% +/- 0.3034% (-106.37 +/- 18.25)\npage-faults:u: -0.1834% +/- 0.0863% (-218.80 +/- 103.00)\ncycles:u: -1.8163% +/- 0.2668% (-456090610.64 +/- 66985831.74)\ninstructions:u: -1.1851% +/- 0.0007% (-365653999.24 +/- 220539.29)\nbranch-misses:u: -2.8468% +/- 1.0580% (-2611811.72 +/- 970666.69)\nseconds time elapsed: -1.7687% +/- 0.3026% (-0.11 +/- 0.02)\nseconds user: -1.9723% +/- 0.4480% (-0.11 +/- 0.03)\n\nmsec task-clock:u: -1.7787% +/- 0.3042% (-107.07 +/- 18.31)\npage-faults:u: -0.2413% +/- 0.1050% (-288.12 +/- 125.39)\nL1-icache-load-misses: 0.5218% +/- 0.1599% (2523027.12 +/- 773363.93)\nLLC-loads: -2.2917% +/- 0.1613% (-1125147.16 +/- 79181.20)\nLLC-load-misses: -2.0256% +/- 0.2667% (-670484.64 +/- 88293.18)\nseconds time elapsed: -1.7793% +/- 0.3036% (-0.11 +/- 0.02)\nseconds user: -1.7392% +/- 0.3752% (-0.10 +/- 0.02)\n```\n\nAnd for the scanner benchmark, in AOT mode, called with\n`pkg/_fe_analyzer_shared/lib/src/parser/parser_impl.dart --bytes` for bytes per microsecond:\n\n```\n    N           Min           Max        Median           Avg        Stddev\nx  25     114.87867     117.70322     117.10106        116.85    0.67188864\n+  25       153.512     156.99315     156.38671     155.95981    0.98376554\nDifference at 95.0% confidence\n        39.1098 +/- 0.479146\n        33.4701% +/- 0.410053%\n        (Student\u0027s t, pooled s \u003d 0.842386)\n```\n\nChange-Id: Ica6d47d92ab0fb4c3a06aa6686b8c71f52a6aef8\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/407480\nCommit-Queue: Jens Johansen \u003cjensj@google.com\u003e\nReviewed-by: Johnni Winther \u003cjohnniwinther@google.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "ec14a5db8647cc2adc5d2a73765f3348c7553036",
      "old_mode": 33188,
      "old_path": "pkg/_fe_analyzer_shared/lib/src/scanner/abstract_scanner.dart",
      "new_id": "4f9250a417526db9ecbf8554ef34c6e2662b802a",
      "new_mode": 33188,
      "new_path": "pkg/_fe_analyzer_shared/lib/src/scanner/abstract_scanner.dart"
    },
    {
      "type": "modify",
      "old_id": "b29dd83d7c858823accd6f3367f6994ea660ae8d",
      "old_mode": 33188,
      "old_path": "pkg/_fe_analyzer_shared/lib/src/scanner/keyword_state.dart",
      "new_id": "21aa801a025041a23ebdf690e9d1ef5450aea836",
      "new_mode": 33188,
      "new_path": "pkg/_fe_analyzer_shared/lib/src/scanner/keyword_state.dart"
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "6f28fe9a6038f428ed26e860be80498018b1532f",
      "new_mode": 33188,
      "new_path": "pkg/_fe_analyzer_shared/test/keyword_state_test.dart"
    },
    {
      "type": "modify",
      "old_id": "90ccad8b170b88bf46a2ec0aa2eb8b1500a3435c",
      "old_mode": 33188,
      "old_path": "pkg/front_end/test/spell_checking_list_code.txt",
      "new_id": "b4a66e518bc1c22f7ca57f20acdf34fc3ae5c4a6",
      "new_mode": 33188,
      "new_path": "pkg/front_end/test/spell_checking_list_code.txt"
    }
  ]
}