| commit | c5a954794b30f89a20d02e2f19a9561bcc96333e | [log] [tgz] |
|---|---|---|
| author | Sam Rawlins <srawlins@google.com> | Tue Jan 29 02:01:51 2019 +0000 |
| committer | commit-bot@chromium.org <commit-bot@chromium.org> | Tue Jan 29 02:01:51 2019 +0000 |
| tree | 2903cb5e443dd27e9fcd3200177dbcf9ae752f5b | |
| parent | d84851daf86b48300637cc34c38f6f9ffb5cd8a8 [diff] |
Fix PackageBuildWorkspacePackage's contains This implementation did not check whether the path was actually contained in the package:build workspace. It also made an assumption about how a resource which is a directory would be treated, which was masked by an unconditional-and-silenced catch. The existing test which should have caught this had a hidden exception, caught by the same unconditional-and-silenced catch. :( Bug: https://github.com/dart-lang/linter/issues/1393 Change-Id: I0a6ecb584e06877463a47681830eed8f6f914030 Reviewed-on: https://dart-review.googlesource.com/c/91441 Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> Commit-Queue: Samuel Rawlins <srawlins@google.com>
Dart is an open-source, scalable programming language, with robust libraries and runtimes, for building web, server, and mobile apps.
Visit the dartlang.org to learn more about the language, tools, getting started, and more.
Browse pub.dartlang.org for more packages and libraries contributed by the community and the Dart team.
If you want to build Dart yourself, here is a guide to getting the source, preparing your machine to build the SDK, and building.
There are more documents on our wiki.
The easiest way to contribute to Dart is to file issues.
You can also contribute patches, as described in Contributing.