commit 9bdc2b6f4d40824b1c0b65ff1bd1a24290e634be
author Martin Kustermann <kustermann@google.com> Fri Aug 16 10:39:28 2024 +0000
committer Commit Queue <dart-scoped@luci-project-accounts.iam.gserviceaccount.com> Fri Aug 16 10:39:28 2024 +0000
tree c0ce7f7cee13948cba3ff603cd66cef3918b120b
parent 8c02ad43e01a6f1b51f0d39a4b1a0e799b2f0b83

[beta] Revert "analyzer: separate unused_element_parameter from unused_element"

This reverts commit c1976b097d1f85fe2c8fa4cab1d0d51cc7e92b42.

Note: this is the second attempt at reverting this CL. The previous commit claimed to do the revert but did not actually revert the code.

Reason for revert: It seems this change caused failures on Flutter
HHH bot. Example log can be found at [0]:
```
| lib/src/super_reader/super_reader.dart:615:14: Error: Final field 'showDebugLeaderBounds' is not initialized.
| Try to initialize the field in the declaration or in every constructor.
|   final bool showDebugLeaderBounds;
|              ^^^^^^^^^^^^^^^^^^^^^

```
Looking at the sources it seems that may be related to the
`// ignore: unused_element` analyzer directive:

```
   602	/// A [SuperReaderDocumentLayerBuilder] that builds a [SelectionLeadersDocumentLayer], which positions
   603	/// leader widgets at the base and extent of the user's selection, so that other widgets
   604	/// can position themselves relative to the user's selection.
   605	class _SelectionLeadersDocumentLayerBuilder implements SuperReaderDocumentLayerBuilder {
   606	  const _SelectionLeadersDocumentLayerBuilder({
   607	    required this.links,
   608	    // ignore: unused_element
   609	    this.showDebugLeaderBounds = false,
   610	  });
   611
   612	  /// Collections of [LayerLink]s, which are given to leader widgets that are
   613	  /// positioned at the selection bounds, and around the full selection.
   614	  final SelectionLayerLinks links;
   615
   616	  /// Whether to paint colorful bounds around the leader widgets, for debugging purposes.
   617	  final bool showDebugLeaderBounds;
```

So tentatively reverting this CL.

[0] https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket/8739650477551803313/+/u/Run_customer_testing_tests/stdout

Original change's description:
> analyzer: separate unused_element_parameter from unused_element
>
> Fixes https://github.com/dart-lang/sdk/issues/49025
>
> This allows users to blanket ignore unused_element_parameter without
> ignoring unused_element. They are reported in distinct situations so it
> is valid to separate them.
>
> Tested: Presubmit CI
> Cq-Include-Trybots: luci.dart.try:flutter-analyze-try,analyzer-win-release-try,pkg-win-release-try
> Change-Id: I4844a6a0e0a67cd5e37ed8735b1526e174deb950
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/378500
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
> Reviewed-by: Phil Quitslund <pquitslund@google.com>
> Commit-Queue: Samuel Rawlins <srawlins@google.com>
> Reviewed-by: Ryan Macnak <rmacnak@google.com>

Change-Id: I85c98a2d8b24d38d438015e7a10bd99ab914fc7a
Cq-Include-Trybots: luci.dart.try:analyzer-win-release-try,pkg-win-release-try
Cherry-pick: https://dart-review.googlesource.com/c/sdk/+/380460
Cherry-pick-request: https://github.com/dart-lang/sdk/issues/56486
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/380703
Reviewed-by: Slava Egorov <vegorov@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>