| commit | c507acfae480c9a5a88630d9a91ce01c6691a856 | [log] [tgz] |
|---|---|---|
| author | Sigmund Cherem <sigmund@google.com> | Tue Feb 12 18:53:43 2019 +0000 |
| committer | commit-bot@chromium.org <commit-bot@chromium.org> | Tue Feb 12 18:53:43 2019 +0000 |
| tree | 2cc263edc125980dc4b40797083a7609f2a2f98f | |
| parent | 0541640e3793cf97a97437075b49e0228c446c80 [diff] |
Fix Js-interop factory calls which broke when eliding optional parameters. The issue derives from the fact that `parameterStructure` has only the preserved parameters, however the SSA was emitting values for all arguments. I fixed this by emitting all parameters. I also noticed that the parameter order should probably be the native-ordering here as well (it doesn't matter for the factory, but it may matter for other static native calls, if any) Bug: https://github.com/dart-lang/sdk/issues/35916 Change-Id: I2e93c7f8e3baf5c9285107d23786bb3bf4f3a511 Reviewed-on: https://dart-review.googlesource.com/c/92626 Commit-Queue: Sigmund Cherem <sigmund@google.com> Reviewed-by: Stephen Adams <sra@google.com>
Dart is an open-source, scalable programming language, with robust libraries and runtimes, for building web, server, and mobile apps.
Visit the dartlang.org to learn more about the language, tools, getting started, and more.
Browse pub.dartlang.org for more packages and libraries contributed by the community and the Dart team.
If you want to build Dart yourself, here is a guide to getting the source, preparing your machine to build the SDK, and building.
There are more documents on our wiki.
The easiest way to contribute to Dart is to file issues.
You can also contribute patches, as described in Contributing.