commit | c1e535031d24e7c8b2fd4b24a205c8edf5c7a113 | [log] [tgz] |
---|---|---|
author | Sam Rawlins <srawlins@google.com> | Tue Nov 12 17:03:39 2024 +0000 |
committer | Commit Queue <dart-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Nov 12 17:03:39 2024 +0000 |
tree | 09ccbda17c050c8143583c6b82c3331d6e565b99 | |
parent | 74d84f397e3a4e8a30674ae4b75b411453773d9e [diff] |
analyzer: Simplyify propagating lint rule exceptions I found that the `propagateLinterExceptions` analysis option was being passed to the AnalysisRuleExceptionHandler class at approximately the same point where the exception handler is called, and also that the AnalysisRuleExceptionHandler class's `logException` method did not _use_ the `propagateLinterExceptions` value; it just _unconditionally_ returned it. So it gave it back to nearly the same code that passed it in. So we can simplify all of this by removing the `propagateExceptions` field in AnalysisRuleExceptionHandler. But then that class has zero fields and one method. _And_ that one method is _the only_ ,method that is ever passed in to AnalysisRuleVisitor as the exception handler. So remove the class altogether, and inline the method in AnalysisRuleVisitor. AnalysisRuleVisitor instead takes the bool value, `shouldPropagateExceptions`, and does the right thing with it. Additionally: * Privatize AnalysisRuleVisitor `registry` property. * Make AnalysisOptionsImpl `propagateLinterExceptions` property final. Change-Id: Ia438881a3eccb3e26ebed294a7b7b8329d7961ed Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/393902 Reviewed-by: Phil Quitslund <pquitslund@google.com> Commit-Queue: Samuel Rawlins <srawlins@google.com>
Dart is:
Approachable: Develop with a strongly typed programming language that is consistent, concise, and offers modern language features like null safety and patterns.
Portable: Compile to ARM, x64, or RISC-V machine code for mobile, desktop, and backend. Compile to JavaScript or WebAssembly for the web.
Productive: Make changes iteratively: use hot reload to see the result instantly in your running app. Diagnose app issues using DevTools.
Dart's flexible compiler technology lets you run Dart code in different ways, depending on your target platform and goals:
Dart Native: For programs targeting devices (mobile, desktop, server, and more), Dart Native includes both a Dart VM with JIT (just-in-time) compilation and an AOT (ahead-of-time) compiler for producing machine code.
Dart Web: For programs targeting the web, Dart Web includes both a development time compiler (dartdevc) and a production time compiler (dart2js).
Dart is free and open source.
See LICENSE and PATENT_GRANT.
Visit dart.dev to learn more about the language, tools, and to find codelabs.
Browse pub.dev for more packages and libraries contributed by the community and the Dart team.
Our API reference documentation is published at api.dart.dev, based on the stable release. (We also publish docs from our beta and dev channels, as well as from the primary development branch).
If you want to build Dart yourself, here is a guide to getting the source, preparing your machine to build the SDK, and building.
There are more documents in our repo at docs.
The easiest way to contribute to Dart is to file issues.
You can also contribute patches, as described in Contributing.
Future plans for Dart are included in the combined Dart and Flutter roadmap on the Flutter wiki.