commit bfeb270b2158d0310abdfd3c75c4296345613cf8
author Zach Anderson <zra@google.com> Tue Sep 18 15:30:15 2018 +0000
committer commit-bot@chromium.org <commit-bot@chromium.org> Tue Sep 18 15:30:15 2018 +0000
tree 6572b7614b18e6340cea441ee76b49e525b367d7
parent ba5a4bd8c4ddab95a62c6996d028291e1783195d

[tests] Try dartkb with different vm flags

This change modifies the test matrix to run with --compiler=dartkb with
--enable_interpreter and --use_bytecode_compiler in sequence.

Change-Id: Ie1be3ffdd97e65ceafb8838fd1b159746ba4c2cb
Reviewed-on: https://dart-review.googlesource.com/75206
Commit-Queue: Zach Anderson <zra@google.com>
Reviewed-by: Régis Crelier <regis@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>

tools/bots/test_matrix.json

diff --git a/tools/bots/test_matrix.json b/tools/bots/test_matrix.json
index 6f1e290..088da9b 100644
--- a/tools/bots/test_matrix.json
+++ b/tools/bots/test_matrix.json
@@ -407,7 +407,14 @@
         "preview-dart-2": false
       }},
     "app_jitk-linux-(debug|product|release)-x64": { },
-    "dartkb-linux-(debug|release)-x64": { },
+    "dartkb-interpret-linux-(debug|release)-x64": {
+      "options": {
+        "vm-options": ["--enable_interpreter"]
+      }},
+    "dartkb-compile-linux-(debug|release)-x64": {
+      "options": {
+        "vm-options": ["--use_bytecode_compiler"]
+      }},
     "(dartdevc|dartdevk)-checked-(linux|mac|win)-release-chrome": {
       "options": {
         "checked": true,
@@ -516,14 +523,21 @@
           "name": "build dart",
           "script": "tools/build.py",
           "arguments": [
-            "--bytecode",
             "runtime"
           ]
         },
         {
-          "name": "vm tests",
+          "name": "vm interpreter tests",
           "arguments": [
-            "-ndartkb-linux-${mode}-x64",
+            "-ndartkb-interpret-linux-${mode}-x64",
+            "--compiler=dartkb",
+            "language_2"
+          ]
+        },
+        {
+          "name": "vm bytecode compiler tests",
+          "arguments": [
+            "-ndartkb-compile-linux-${mode}-x64",
             "--compiler=dartkb",
             "language_2"
           ]

tools/testing/dart/compiler_configuration.dart

diff --git a/tools/testing/dart/compiler_configuration.dart b/tools/testing/dart/compiler_configuration.dart
index 30f5938b..8f039d7 100644
--- a/tools/testing/dart/compiler_configuration.dart
+++ b/tools/testing/dart/compiler_configuration.dart
@@ -247,9 +247,6 @@
     } else if (_configuration.hotReloadRollback) {
       args.add('--hot-reload-rollback-test-mode');
     }
-    if (_configuration.useKernelBytecode) {
-      args.add('--enable_interpreter');
-    }
     return args
       ..addAll(vmOptions)
       ..addAll(sharedOptions)