tree 8a77d01c35d15932a274f7dd1768f4be3f0d3e10
parent 7984dc4fcc5352a0df68ad7b4f478ace7ae65842
author Danny Tuppeny <dantup@google.com> 1547657863 +0000
committer commit-bot@chromium.org <commit-bot@chromium.org> 1547657863 +0000

Fix LSP exceptions serializing ResponseErrors with Uris

The ResponseError.data field was typed `dynamic` (as in the LSP spec) but this allows us to accidentally put non-serializable classes in it which will result in server errors when we try to send them back.

This change forces them to Strings and it's up to the code constructing the error to convert any additional data to a string first.

In order to catch this in tests, the mocks now force serialisation of all types flowing from the server to the client (this already happened for client to server).

Change-Id: I5d7f322e1a4296b1479468e36d81daebdbb4ab52
Reviewed-on: https://dart-review.googlesource.com/c/89511
Commit-Queue: Danny Tuppeny <dantup@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>