| commit | bedcd576560c386e6930573e97ee82596b69fdfe | [log] [tgz] |
|---|---|---|
| author | Jens Johansen <jensj@google.com> | Tue Feb 14 07:38:38 2023 +0000 |
| committer | Commit Queue <dart-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Feb 14 07:38:38 2023 +0000 |
| tree | dd929aecd35a1b9898ebd4350639716b766216b0 | |
| parent | fc28153cc1c7552cd6a064c39c8e73854034d7c8 [diff] |
[analyzer] Faster relative-path-if-inside-same-dir function for `AbstractDartSdk.getPath`
AbstractDartSdk._getPath has some "phases" trying to determine a
"dart import uri" from a File.
One of these phases checks if the given file is inside a directory that
one of the known sdk platforms is inside, thus allowing us to construct
a uri from there.
For instance if we know that `/a/b/c/d/e.dart` is called
`dart:foo/e.dart` and we’re presented with `/a/b/c/d/f.dart` we’ll
figure out that it’s called `dart:foo/f.dart`.
The code for this is very simple, but very inefficient.
This CL makes it more efficient.
This is only applicable when analyzing with the flutter platform.
The below benchmarks show a ~7 to ~33% improvement depending on what's
being analyzed. It's all done via `dart analyze` where the first run
has been discarded so everything is in cache.
Running on `rwf-materials`:
```
Before:
real 1m54.491s
real 1m55.969s
real 1m53.802s
Now:
real 1m16.348s
real 1m17.570s
real 1m17.149s
Difference at 95.0% confidence
-37.7317 +/- 1.06819
-32.8805% +/- 0.930855%
(Student's t, pooled s = 0.471277)
```
Running on "flutter gallery":
```
Before:
real 0m2.836s
real 0m2.783s
real 0m2.718s
Now:
real 0m2.478s
real 0m2.492s
real 0m2.451s
Difference at 95.0% confidence
-0.305333 +/- 0.10044
-10.9872% +/- 3.61426%
(Student's t, pooled s = 0.0443133)
```
Running on "flutter-wonderous-app":
```
Before:
real 0m2.019s
real 0m1.999s
real 0m1.984s
Now:
real 0m1.863s
real 0m1.821s
real 0m1.856s
Difference at 95.0% confidence
-0.154 +/- 0.0457455
-7.69743% +/- 2.28652%
(Student's t, pooled s = 0.0201825)
```
Running on "flutter gallery" and "flutter-wonderous-app" at the same time:
```
Before:
real 0m3.446s
real 0m3.407s
real 0m3.431s
Now:
real 0m2.993s
real 0m2.965s
real 0m3.008s
Difference at 95.0% confidence
-0.439333 +/- 0.0470921
-12.816% +/- 1.37375%
(Student's t, pooled s = 0.0207766)
```
Change-Id: I13e81e96312d9cb5ad2a8244a0cb7722a49c4460
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/282280
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Dart is:
Optimized for UI: Develop with a programming language specialized around the needs of user interface creation.
Productive: Make changes iteratively: use hot reload to see the result instantly in your running app.
Fast on all platforms: Compile to ARM & x64 machine code for mobile, desktop, and backend. Or compile to JavaScript for the web.
Dart's flexible compiler technology lets you run Dart code in different ways, depending on your target platform and goals:
Dart Native: For programs targeting devices (mobile, desktop, server, and more), Dart Native includes both a Dart VM with JIT (just-in-time) compilation and an AOT (ahead-of-time) compiler for producing machine code.
Dart Web: For programs targeting the web, Dart Web includes both a development time compiler (dartdevc) and a production time compiler (dart2js).
Dart is free and open source.
See LICENSE and PATENT_GRANT.
Visit dart.dev to learn more about the language, tools, and to find codelabs.
Browse pub.dev for more packages and libraries contributed by the community and the Dart team.
Our API reference documentation is published at api.dart.dev, based on the stable release. (We also publish docs from our beta and dev channels, as well as from the primary development branch).
If you want to build Dart yourself, here is a guide to getting the source, preparing your machine to build the SDK, and building.
There are more documents on our wiki.
The easiest way to contribute to Dart is to file issues.
You can also contribute patches, as described in Contributing.