[vm/service] Add disable_origin_check to API
This adds a boolean disable_origin_check field to struct
VmServiceConfiguration in dart_embedder_api.h and forwards it to
bin::VmService::Setup, allowing embedders (such as Flutter Engine) to
disable WebSocket origin and host checks when running in remote lab
environments.
When CL 515120 was originally landed, it broke Flutter Engine because
programmatic embedders had no mechanism on VmServiceConfiguration to
disable WebSocket origin and host verification. Furthermore, when the
VM Service spawned DDS in detached mode, it did not forward origin
check disablement flags. This change bridges the C++ embedder API
directly into bin::VmService::Setup.
How this was tested:
We cherry-picked CL 515120 (commit 7b572a26bdb0) and rebuilt the
runtime, service snapshots, and standalone binary. When
pkg/vm_service/test/origin_check_disabled_test.dart was run without
--disable-service-origin-check passed in VMOptions, the test failed as
expected with HTTP 403 Forbidden:
origin_check_disabled_test.dart [1/1]
TESTING WS URI: ws://127.0.0.1:41689/ws
+0 -1: origin_check_disabled_test.dart [E]
WebSocketException: Connection to 'http://127.0.0.1:41689/ws#'
was not upgraded to websocket, HTTP status code: 403
When --disable-service-origin-check was provided, the connection
upgrade succeeded and the test passed 100%.
Bug: b/528429998
TEST=runtime/vm/dart_api_impl_test.cc
TEST=pkg/vm_service/test/origin_check_disabled_test.dart
TEST=pkg/vm_service/test/origin_check_rejected_test.dart
Change-Id: I40f4915ba1063c3b6d32b6225acf7be07713ef47
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/518525
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
Dart is:
Approachable: Develop with a strongly typed programming language that is consistent, concise, and offers modern language features like null safety and patterns.
Portable: Compile to ARM, x64, or RISC-V machine code for mobile, desktop, and backend. Compile to JavaScript or WebAssembly for the web.
Productive: Make changes iteratively: use hot reload to see the result instantly in your running app. Diagnose app issues using DevTools.
Dart's flexible compiler technology lets you run Dart code in different ways, depending on your target platform and goals:
Dart Native: For programs targeting devices (mobile, desktop, server, and more), Dart Native includes both a Dart VM with JIT (just-in-time) compilation and an AOT (ahead-of-time) compiler for producing machine code.
Dart Web: For programs targeting the web, Dart Web includes both a development time compiler (dartdevc) and a production time compiler (dart2js).
Dart is free and open source.
See LICENSE and PATENT_GRANT.
Visit dart.dev to learn more about the language, tools, and to find codelabs.
Browse pub.dev for more packages and libraries contributed by the community and the Dart team.
Our API reference documentation is published at api.dart.dev, based on the stable release. (We also publish docs from our beta and dev channels, as well as from the primary development branch).
If you want to build Dart yourself, here is a guide to getting the source, preparing your machine to build the SDK, and building.
There are more documents in our repo at docs.
The easiest way to contribute to Dart is to file issues.
You can also contribute patches, as described in Contributing.
Future plans for Dart are included in the combined Dart and Flutter roadmap on the Flutter wiki.