commit | bafb34cc7f11f814e69b91c157fd1c2d8868e13a | [log] [tgz] |
---|---|---|
author | Daco Harkes <dacoharkes@google.com> | Thu Dec 15 11:41:23 2022 +0000 |
committer | Commit Queue <dart-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Dec 15 11:41:23 2022 +0000 |
tree | 579f888e797168db9fcc3e8fc84d3eeda9d98977 | |
parent | 1381832b47dec4f0ece68010627239c407e8f70e [diff] |
[beta][vm/ffi] Fix FfiTrampolineData GC bug This lets the GC visit FfiTrampolineData::c_signature again. https://dart-review.googlesource.com/c/sdk/+/272201 stopped adding FfiTrampolineData::c_signature to snapshots. However, instead of skipping it manually in app_shapshot.cc, we skipped it in raw_object.h, which also caused the GC to skip it. This CL adds it back in as we need it in JIT snapshots. This way we keep it consistent between AOT/JIT snapshots. TEST=tests/ffi/regress_b_261224444_test.dart The c signatures of FFI trampolines were not properly traced in the precompiler, causing us to hit an assert when the classes mentioned in those types where only referenced from a signature and not retained for any other reason. TEST=tests/ffi/native_assets/process_test.dart (dartkp) Closes: https://github.com/dart-lang/sdk/issues/50678 Bug: b/261224444 Change-Id: I104089db384224bac429a910787b04fd407b2bb5 Cherry-pick: https://dart-review.googlesource.com/c/sdk/+/274387 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/275060 Reviewed-by: Martin Kustermann <kustermann@google.com> Commit-Queue: Daco Harkes <dacoharkes@google.com>
Dart is:
Optimized for UI: Develop with a programming language specialized around the needs of user interface creation.
Productive: Make changes iteratively: use hot reload to see the result instantly in your running app.
Fast on all platforms: Compile to ARM & x64 machine code for mobile, desktop, and backend. Or compile to JavaScript for the web.
Dart's flexible compiler technology lets you run Dart code in different ways, depending on your target platform and goals:
Dart Native: For programs targeting devices (mobile, desktop, server, and more), Dart Native includes both a Dart VM with JIT (just-in-time) compilation and an AOT (ahead-of-time) compiler for producing machine code.
Dart Web: For programs targeting the web, Dart Web includes both a development time compiler (dartdevc) and a production time compiler (dart2js).
Dart is free and open source.
See LICENSE and PATENT_GRANT.
Visit dart.dev to learn more about the language, tools, and to find codelabs.
Browse pub.dev for more packages and libraries contributed by the community and the Dart team.
Our API reference documentation is published at api.dart.dev, based on the stable release. (We also publish docs from our beta and dev channels, as well as from the primary development branch).
If you want to build Dart yourself, here is a guide to getting the source, preparing your machine to build the SDK, and building.
There are more documents on our wiki.
The easiest way to contribute to Dart is to file issues.
You can also contribute patches, as described in Contributing.