commit ba596c51a3181dfed9cadd1807e4497c5278ac1b
author Ömer Sinan Ağacan <omersa@google.com> Wed Nov 15 11:41:15 2023 +0000
committer Commit Queue <dart-scoped@luci-project-accounts.iam.gserviceaccount.com> Wed Nov 15 11:41:15 2023 +0000
tree 1e2dacabe49c3fc9b27e59161239459a72ffb7da
parent bf587fbb71bcacf4f8b4bcb9ffa36c02b28b3765

[dart2wasm] Simplify native ByteBuffer implmenetation view conversions

After checking alignment of the offset we know that it's aligned (as the
check throws otherwise), so we return the fast view class without
checking the alignment again.

Change-Id: I11e64cf867da8a837e6087ee6548cc509e686ab7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/336360
Reviewed-by: Aske Simon Christensen <askesc@google.com>
Commit-Queue: Ömer Ağacan <omersa@google.com>

sdk/lib/_internal/wasm/lib/typed_data.dart

diff --git a/sdk/lib/_internal/wasm/lib/typed_data.dart b/sdk/lib/_internal/wasm/lib/typed_data.dart
index 46e22e5..72ea793 100644
--- a/sdk/lib/_internal/wasm/lib/typed_data.dart
+++ b/sdk/lib/_internal/wasm/lib/typed_data.dart
@@ -1168,13 +1168,8 @@
     _rangeCheck(
         lengthInBytes, offsetInBytes, length * Int16List.bytesPerElement);
     _offsetAlignmentCheck(offsetInBytes, Int16List.bytesPerElement);
-    if (offsetInBytes % Int16List.bytesPerElement != 0) {
-      return _SlowI16List._withMutability(
-          this, offsetInBytes, length, _mutable);
-    } else {
-      return I16List._withMutability(
-          _data, offsetInBytes ~/ Int16List.bytesPerElement, length, _mutable);
-    }
+    return I16List._withMutability(
+        _data, offsetInBytes ~/ Int16List.bytesPerElement, length, _mutable);
   }
 
   @override
@@ -1183,13 +1178,8 @@
     _rangeCheck(
         lengthInBytes, offsetInBytes, length * Uint16List.bytesPerElement);
     _offsetAlignmentCheck(offsetInBytes, Uint16List.bytesPerElement);
-    if (offsetInBytes % Uint16List.bytesPerElement != 0) {
-      return _SlowU16List._withMutability(
-          this, offsetInBytes, length, _mutable);
-    } else {
-      return U16List._withMutability(
-          _data, offsetInBytes ~/ Uint16List.bytesPerElement, length, _mutable);
-    }
+    return U16List._withMutability(
+        _data, offsetInBytes ~/ Uint16List.bytesPerElement, length, _mutable);
   }
 
   @override
@@ -1220,13 +1210,8 @@
     _rangeCheck(
         lengthInBytes, offsetInBytes, length * Int32List.bytesPerElement);
     _offsetAlignmentCheck(offsetInBytes, Int32List.bytesPerElement);
-    if (offsetInBytes % Uint32List.bytesPerElement != 0) {
-      return _SlowI32List._withMutability(
-          this, offsetInBytes, length, _mutable);
-    } else {
-      return I32List._withMutability(
-          _data, offsetInBytes ~/ Int32List.bytesPerElement, length, _mutable);
-    }
+    return I32List._withMutability(
+        _data, offsetInBytes ~/ Int32List.bytesPerElement, length, _mutable);
   }
 
   @override
@@ -1235,13 +1220,8 @@
     _rangeCheck(
         lengthInBytes, offsetInBytes, length * Uint32List.bytesPerElement);
     _offsetAlignmentCheck(offsetInBytes, Uint32List.bytesPerElement);
-    if (offsetInBytes % Uint32List.bytesPerElement != 0) {
-      return _SlowU32List._withMutability(
-          this, offsetInBytes, length, _mutable);
-    } else {
-      return U32List._withMutability(
-          _data, offsetInBytes ~/ Uint32List.bytesPerElement, length, _mutable);
-    }
+    return U32List._withMutability(
+        _data, offsetInBytes ~/ Uint32List.bytesPerElement, length, _mutable);
   }
 
   @override
@@ -1272,13 +1252,8 @@
     _rangeCheck(
         lengthInBytes, offsetInBytes, length * Int64List.bytesPerElement);
     _offsetAlignmentCheck(offsetInBytes, Int64List.bytesPerElement);
-    if (offsetInBytes % Int64List.bytesPerElement != 0) {
-      return _SlowI64List._withMutability(
-          this, offsetInBytes, length, _mutable);
-    } else {
-      return I64List._withMutability(
-          _data, offsetInBytes ~/ Int64List.bytesPerElement, length, _mutable);
-    }
+    return I64List._withMutability(
+        _data, offsetInBytes ~/ Int64List.bytesPerElement, length, _mutable);
   }
 
   @override
@@ -1287,13 +1262,8 @@
     _rangeCheck(
         lengthInBytes, offsetInBytes, length * Uint64List.bytesPerElement);
     _offsetAlignmentCheck(offsetInBytes, Uint64List.bytesPerElement);
-    if (offsetInBytes % Int64List.bytesPerElement != 0) {
-      return _SlowU64List._withMutability(
-          this, offsetInBytes, length, _mutable);
-    } else {
-      return U64List._withMutability(
-          _data, offsetInBytes ~/ Uint64List.bytesPerElement, length, _mutable);
-    }
+    return U64List._withMutability(
+        _data, offsetInBytes ~/ Uint64List.bytesPerElement, length, _mutable);
   }
 
   @override
@@ -1324,13 +1294,8 @@
     _rangeCheck(
         lengthInBytes, offsetInBytes, length * Float32List.bytesPerElement);
     _offsetAlignmentCheck(offsetInBytes, Float32List.bytesPerElement);
-    if (offsetInBytes % Float32List.bytesPerElement != 0) {
-      return _SlowF32List._withMutability(
-          this, offsetInBytes, length, _mutable);
-    } else {
-      return F32List._withMutability(_data,
-          offsetInBytes ~/ Float32List.bytesPerElement, length, _mutable);
-    }
+    return F32List._withMutability(
+        _data, offsetInBytes ~/ Float32List.bytesPerElement, length, _mutable);
   }
 
   @override
@@ -1361,12 +1326,8 @@
     _rangeCheck(
         lengthInBytes, offsetInBytes, length * Float64List.bytesPerElement);
     _offsetAlignmentCheck(offsetInBytes, Float64List.bytesPerElement);
-    if (offsetInBytes % Float64List.bytesPerElement != 0) {
-      return SlowF64List._withMutability(this, offsetInBytes, length, _mutable);
-    } else {
-      return F64List._withMutability(
-          _data, offsetInBytes ~/ Int64List.bytesPerElement, length, _mutable);
-    }
+    return F64List._withMutability(
+        _data, offsetInBytes ~/ Int64List.bytesPerElement, length, _mutable);
   }
 
   @override