tree 076b7a5dd6b04a6394e2d7298b7e448931af5b53
parent 725553b5b984a856b2eb0084e145e54731392c8e
author Sam Rawlins <srawlins@google.com> 1743108967 -0700
committer Commit Queue <dart-scoped@luci-project-accounts.iam.gserviceaccount.com> 1743108967 -0700

DAS: Rearrange code to promote variables better

The motivation here was to remove the local duplicate variable,
`final_propertiesBuilderName`. This variable only existed because the
variable it duplicates loses its promoted type inside the `builder.addDartFileEdit` closure. It loses its promoted type because
it is multiply assigned in a for loop.

This CL extracts a portion of the `compute()` method, which is solely
concerned with computing the real "target". The diff looks large
because of how that portion is moved into a helper method that is
_below_ `compute()`.

I think each of these changes then improves readability: extracting
part of a 180-line long method into one helper, and avoiding a local
duplicate variable.

Change-Id: I96b6ccdbd627d3cf3cc4b7f7bbcba7ee5dd9a561
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/417700
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>