analyzer: Follow-up work for @mustBeConst

The two big items are catching two more types of invocations: RedirectingConstructorInvocation and SuperConstructorInvocation. See the new tests, `test_redirectingConstructor_variable_fails` and `test_superConstructor_variable_fails`.

I also restructured the test names, trying to be a little more consistent. What I chose is `test_<parameterTypeOrLocation>_<argumentType>_[fails|succeeds]`. I also flipped combos like "named required" to be "required named", following the convention of the language guide [1]. These renames mean the tests are in a completely different order, and the diff is large.

I also add a test for non-function type alias as constructor, named `test_typedef_nonFunction_variable_fails`.

And some minor edits:

* We use `var` instead of `final` for locals.
* Rename the test from 'const_argument_test' to the name of the
  diagnostic being reported.
* Remove the commented out code for `test_functionType_variable_fails`
  and make this a real test.
* Use void as function return types and use empty bodies.
* Simplify tests, notably the `binaryExpression` ones.

[1]: https://dart.dev/language/functions


Change-Id: If2378c19880b68a2b87609fee012db60c55c3931
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/361125
Reviewed-by: Moritz Sümmermann <mosum@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>