| commit | b8ff81ea0db6905393fec07b5308aad3e0243f5c | [log] [tgz] |
|---|---|---|
| author | Nate Biggs <natebiggs@google.com> | Thu Sep 12 17:59:36 2024 +0000 |
| committer | Commit Queue <dart-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Sep 12 17:59:36 2024 +0000 |
| tree | 56f5e7c655233e5dc030d0b73292e381d574ea2d | |
| parent | 43698dbed37e0c442b8a1d4dfb0943b69c363f94 [diff] |
[dart2wasm] Fix while scoping in async generator. The new test was resulting in an uninitialized late read of localContext here: https://github.com/dart-lang/sdk/blob/main/pkg/dart2wasm/lib/code_generator.dart#L830 The `++i` results in a let expression declaring a new variable within the condition of the while loop. The code linked above tries to look up the variable within the current context. The `ContextCollector` defines the while scope as including the while's condition: https://github.com/dart-lang/sdk/blob/main/pkg/dart2wasm/lib/closures.dart#L1486 However, the AstCodeGenerator doesn't register the while's scope until after processing the condition: https://github.com/dart-lang/sdk/blob/main/pkg/dart2wasm/lib/code_generator.dart#L1248 So when processing the condition, the loopkup happens on the scope above the while even though the variable is captured on the while's scope. A synthetic let statement is the only way to get a variable declaration within a while's condition. And it wouldn't otherwise be captured (a closure can't reference it) but async function bodies mark all variables as captured. Change-Id: I5f8fdd69d4875c099a21505cd588b08cacdd86c1 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/384863 Reviewed-by: Martin Kustermann <kustermann@google.com>
Dart is:
Approachable: Develop with a strongly typed programming language that is consistent, concise, and offers modern language features like null safety and patterns.
Portable: Compile to ARM, x64, or RISC-V machine code for mobile, desktop, and backend. Compile to JavaScript or WebAssembly for the web.
Productive: Make changes iteratively: use hot reload to see the result instantly in your running app. Diagnose app issues using DevTools.
Dart's flexible compiler technology lets you run Dart code in different ways, depending on your target platform and goals:
Dart Native: For programs targeting devices (mobile, desktop, server, and more), Dart Native includes both a Dart VM with JIT (just-in-time) compilation and an AOT (ahead-of-time) compiler for producing machine code.
Dart Web: For programs targeting the web, Dart Web includes both a development time compiler (dartdevc) and a production time compiler (dart2js).
Dart is free and open source.
See LICENSE and PATENT_GRANT.
Visit dart.dev to learn more about the language, tools, and to find codelabs.
Browse pub.dev for more packages and libraries contributed by the community and the Dart team.
Our API reference documentation is published at api.dart.dev, based on the stable release. (We also publish docs from our beta and dev channels, as well as from the primary development branch).
If you want to build Dart yourself, here is a guide to getting the source, preparing your machine to build the SDK, and building.
There are more documents in our repo at docs.
The easiest way to contribute to Dart is to file issues.
You can also contribute patches, as described in Contributing.
Future plans for Dart are included in the combined Dart and Flutter roadmap on the Flutter wiki.