)]}'
{
  "commit": "b888da751ed8f2174d2ef5bd50eacabb24979745",
  "tree": "04f070ee00d41989a06a10a53a05f7b016ffa327",
  "parents": [
    "3d083d272018bc4f80d14be8cf55175032721bc6"
  ],
  "author": {
    "name": "Martin Kustermann",
    "email": "kustermann@google.com",
    "time": "Wed Aug 14 08:05:37 2024 +0000"
  },
  "committer": {
    "name": "Commit Queue",
    "email": "dart-scoped@luci-project-accounts.iam.gserviceaccount.com",
    "time": "Wed Aug 14 08:05:37 2024 +0000"
  },
  "message": "Revert \"analyzer: separate unused_element_parameter from unused_element\"\n\nThis reverts commit c1976b097d1f85fe2c8fa4cab1d0d51cc7e92b42.\n\nReason for revert: It seems this change caused failures on Flutter\nHHH bot. Example log can be found at [0]:\n```\n| lib/src/super_reader/super_reader.dart:615:14: Error: Final field \u0027showDebugLeaderBounds\u0027 is not initialized.\n| Try to initialize the field in the declaration or in every constructor.\n|   final bool showDebugLeaderBounds;\n|              ^^^^^^^^^^^^^^^^^^^^^\n\n```\nLooking at the sources it seems that may be related to the\n`// ignore: unused_element` analyzer directive:\n\n```\n   602\t/// A [SuperReaderDocumentLayerBuilder] that builds a [SelectionLeadersDocumentLayer], which positions\n   603\t/// leader widgets at the base and extent of the user\u0027s selection, so that other widgets\n   604\t/// can position themselves relative to the user\u0027s selection.\n   605\tclass _SelectionLeadersDocumentLayerBuilder implements SuperReaderDocumentLayerBuilder {\n   606\t  const _SelectionLeadersDocumentLayerBuilder({\n   607\t    required this.links,\n   608\t    // ignore: unused_element\n   609\t    this.showDebugLeaderBounds \u003d false,\n   610\t  });\n   611\n   612\t  /// Collections of [LayerLink]s, which are given to leader widgets that are\n   613\t  /// positioned at the selection bounds, and around the full selection.\n   614\t  final SelectionLayerLinks links;\n   615\n   616\t  /// Whether to paint colorful bounds around the leader widgets, for debugging purposes.\n   617\t  final bool showDebugLeaderBounds;\n```\n\nSo tentatively reverting this CL.\n\n[0] https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket/8739650477551803313/+/u/Run_customer_testing_tests/stdout\n\nOriginal change\u0027s description:\n\u003e analyzer: separate unused_element_parameter from unused_element\n\u003e\n\u003e Fixes https://github.com/dart-lang/sdk/issues/49025\n\u003e\n\u003e This allows users to blanket ignore unused_element_parameter without\n\u003e ignoring unused_element. They are reported in distinct situations so it\n\u003e is valid to separate them.\n\u003e\n\u003e Tested: Presubmit CI\n\u003e Cq-Include-Trybots: luci.dart.try:flutter-analyze-try,analyzer-win-release-try,pkg-win-release-try\n\u003e Change-Id: I4844a6a0e0a67cd5e37ed8735b1526e174deb950\n\u003e Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/378500\n\u003e Reviewed-by: Brian Wilkerson \u003cbrianwilkerson@google.com\u003e\n\u003e Reviewed-by: Phil Quitslund \u003cpquitslund@google.com\u003e\n\u003e Commit-Queue: Samuel Rawlins \u003csrawlins@google.com\u003e\n\u003e Reviewed-by: Ryan Macnak \u003crmacnak@google.com\u003e\n\nChange-Id: Ibbba75fe56601c7c4b5535c9142cf94c2dd80b91\nCq-Include-Trybots: luci.dart.try:flutter-analyze-try,analyzer-win-release-try,pkg-win-release-try\nNo-Presubmit: true\nNo-Tree-Checks: true\nNo-Try: true\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/380460\nCommit-Queue: Martin Kustermann \u003ckustermann@google.com\u003e\nBot-Commit: Rubber Stamper \u003crubber-stamper@appspot.gserviceaccount.com\u003e\nReviewed-by: Slava Egorov \u003cvegorov@google.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "22f745419e5c6718abec1e7a37c365a872b42830",
      "old_mode": 33188,
      "old_path": "pkg/analysis_server/test/src/services/correction/assist/convert_class_to_enum_test.dart",
      "new_id": "f98306f4b4a0591a949a663ad468a359bdba233b",
      "new_mode": 33188,
      "new_path": "pkg/analysis_server/test/src/services/correction/assist/convert_class_to_enum_test.dart"
    },
    {
      "type": "modify",
      "old_id": "14d8d9eb42c61ae82c6d96825399cda36c68997c",
      "old_mode": 33188,
      "old_path": "pkg/analyzer/lib/src/error/codes.g.dart",
      "new_id": "2cf6a1202a9c2d1e22cf6fdd7a3ecafef32a5b50",
      "new_mode": 33188,
      "new_path": "pkg/analyzer/lib/src/error/codes.g.dart"
    },
    {
      "type": "modify",
      "old_id": "335f41e5019d4fc8fc176739634e9cbc1cac3ac4",
      "old_mode": 33188,
      "old_path": "pkg/analyzer/messages.yaml",
      "new_id": "5b2c560df8d5a20efa668e043fe7fb5a46e358da",
      "new_mode": 33188,
      "new_path": "pkg/analyzer/messages.yaml"
    },
    {
      "type": "modify",
      "old_id": "4e46b3da1da54ca8f3d0008794aac7bad3700c48",
      "old_mode": 33188,
      "old_path": "pkg/analyzer/tool/diagnostics/diagnostics.md",
      "new_id": "3d45df2e82f788ee2fd4373ba6f58b124be82fed",
      "new_mode": 33188,
      "new_path": "pkg/analyzer/tool/diagnostics/diagnostics.md"
    },
    {
      "type": "modify",
      "old_id": "1a60dcc55dd958e234db6b369a21aceb8c97f726",
      "old_mode": 33188,
      "old_path": "runtime/observatory/lib/src/elements/debugger.dart",
      "new_id": "05e84d70e038cfd300984cd7e11f7f924c3ae0fd",
      "new_mode": 33188,
      "new_path": "runtime/observatory/lib/src/elements/debugger.dart"
    }
  ]
}