commit b830a444c9697aa5e12cfba29de9c73f6b2bada1
author Konstantin Shcheglov <scheglov@google.com> Fri Aug 15 09:00:52 2025 -0700
committer Commit Queue <dart-scoped@luci-project-accounts.iam.gserviceaccount.com> Fri Aug 15 09:00:52 2025 -0700
tree 688c30cdc3e2eea95564b3dce563b32d02132d2f
parent 9d851a3d91335c90968d9dc66ab39e2cfff6f0ac

Elements. Extract _writeTopLevelVariableElements()

Change-Id: I9d81dd96fb02feb0b115d5b4cbdd5cc3070a5bf6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/445401
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>

pkg/analyzer/lib/src/summary2/bundle_writer.dart

diff --git a/pkg/analyzer/lib/src/summary2/bundle_writer.dart b/pkg/analyzer/lib/src/summary2/bundle_writer.dart
index 3fc9d39..f414e2f 100644
--- a/pkg/analyzer/lib/src/summary2/bundle_writer.dart
+++ b/pkg/analyzer/lib/src/summary2/bundle_writer.dart
@@ -117,16 +117,7 @@
     _writeTopLevelFunctionElements(libraryElement.topLevelFunctions);
     _writeMixinElements(libraryElement.mixins);
     _writeTypeAliasElements(libraryElement.typeAliases);
-
-    // TODO(scheglov): extract
-    _sink.writeList(libraryElement.topLevelVariables, (element) {
-      _writeReference(element.reference);
-      _writeFragments(element.fragments);
-      _writeElementResolution(() {
-        _resolutionSink.writeType(element.type);
-      });
-    });
-
+    _writeTopLevelVariableElements(libraryElement.topLevelVariables);
     _writeGetterElements(libraryElement.getters);
     _writeSetterElements(libraryElement.setters);
     _writeVariableGetterSetterLinking(libraryElement.topLevelVariables);
@@ -727,6 +718,18 @@
     });
   }
 
+  void _writeTopLevelVariableElements(
+    List<TopLevelVariableElementImpl> elements,
+  ) {
+    _sink.writeList(elements, (element) {
+      _writeReference(element.reference);
+      _writeFragments(element.fragments);
+      _writeElementResolution(() {
+        _resolutionSink.writeType(element.type);
+      });
+    });
+  }
+
   void _writeTopLevelVariableFragment(TopLevelVariableFragmentImpl fragment) {
     _writeTemplateFragment(fragment, () {
       _resolutionSink._writeMetadata(fragment.metadata);