| commit | b82c1f979f0316f5b1d59b69f72fcf39931e15c4 | [log] [tgz] |
|---|---|---|
| author | Siva Annamalai <asiva@google.com> | Tue Oct 23 04:41:13 2018 +0000 |
| committer | commit-bot@chromium.org <commit-bot@chromium.org> | Tue Oct 23 04:41:13 2018 +0000 |
| tree | b80b98e47273489198a120e837b0febd3a5c69d0 | |
| parent | 289d2b003a5cb0996b3d62ff8aff74a11109946d [diff] |
Revert "[VM] Fix for issue 34839 - Dart_Cleanup may hang while shutting down" This reverts commit 89c845eba20e1a021dbb6e3fc3372e06b8be6a24. Reason for revert: Seems to cause ASAN failures Original change's description: > [VM] Fix for issue 34839 - Dart_Cleanup may hang while shutting down > the service isolate. > > The service isolate request for shutdown uses a Dart level message > for exiting the isolate, this shuts down the isolate but does not > completely bring the isolate down if there are some open ports. We > have a timer isolate started in the VM isolate and if the shutdown > happens soon enough this port is still open. > > Change-Id: Icfa07c91b8692eb76ba8502063cf6f5cf04832a5 > Reviewed-on: https://dart-review.googlesource.com/c/81200 > Reviewed-by: Ryan Macnak <rmacnak@google.com> > Commit-Queue: Siva Annamalai <asiva@google.com> TBR=rmacnak@google.com,asiva@google.com Change-Id: I0fd4472d277a380b739e602aa3910cc1f96ed89e No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://dart-review.googlesource.com/c/81223 Reviewed-by: Siva Annamalai <asiva@google.com> Commit-Queue: Siva Annamalai <asiva@google.com>
Dart is an open-source, scalable programming language, with robust libraries and runtimes, for building web, server, and mobile apps.
Visit the dartlang.org to learn more about the language, tools, getting started, and more.
Browse pub.dartlang.org for more packages and libraries contributed by the community and the Dart team.
If you want to build Dart yourself, here is a guide to getting the source, preparing your machine to build the SDK, and building.
There are more documents on our wiki.
The easiest way to contribute to Dart is to file issues.
You can also contribute patches, as described in Contributing.