commit b785f7dba85e03d5307f99fb1ee5ec8286d39ece
author Martin Kustermann <kustermann@google.com> Fri Aug 12 21:02:54 2022 +0000
committer Commit Bot <commit-bot@chromium.org> Fri Aug 12 21:02:54 2022 +0000
tree 87ea5fd364dc52fabac5ef2051ab22be5486e770
parent 74be55a127333c9ce43b221845c31995b6fbb2c2

Avoid logging information by-default and never discarding such logs

The analyzer wraps various functionality in logging calls like

    await logger.runAsync('Prepare linked bundles', () async {
      ...
    });

Doing so will cause time being measured and begin/end messages to be
written to a log. Those strings accumulate in a `StringBuffer` that
is never accessed.

For example running analyzer on a big app like flutter can cause
thousands of "--- Prepare linked bundles in 0 ms.  " strings to be
generated and hanged on to.

This CL makes us no longer generate such strings - only if the
creator of a context supplies a [PerformanceLog] explicitly (in which case
it is responsible for draining the messages written to it).

This reduces memory consumption when analyzing flutter by around 3 MB.

TEST=ci

Change-Id: I4979a964f13c63bd2a3cccef97fb702431731139
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/254925
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>