commit | b66dd3d456c3513651cc7d6a76bd0737bc2b6ced | [log] [tgz] |
---|---|---|
author | Paul Berry <paulberry@google.com> | Tue Jun 05 18:29:26 2018 +0000 |
committer | commit-bot@chromium.org <commit-bot@chromium.org> | Tue Jun 05 18:29:26 2018 +0000 |
tree | 364f03961c853e3ec401c41be9089fcbf23f5442 | |
parent | b667be48611dcb43cbb2575fd21dcc77d00ba8a1 [diff] |
Stop using generic comment syntax in observatory. In most cases the correct fix is to simply drop the generic comment syntax (e.g. replace "List/*<Map>*/" with "List"). We can't use the more precise type because the runtime type is actually more general (e.g. when processing an object that came from the JSON parser, all lists have runtime type List<dynamic>, even if their elements happen to be uniform). But we can introduce more precise types when handling substructures. Exception: all JSON-derived maps have type Map<String, dynamic> (since JSON maps always have string keys), so we can use a more precise type when dealing with JSON maps. Change-Id: I48c9dbdda97c11530978212146f74db7b43f5197 Reviewed-on: https://dart-review.googlesource.com/58320 Reviewed-by: Ryan Macnak <rmacnak@google.com> Commit-Queue: Paul Berry <paulberry@google.com>
Dart is an open-source, scalable programming language, with robust libraries and runtimes, for building web, server, and mobile apps.
Visit the dartlang.org to learn more about the language, tools, getting started, and more.
Browse pub.dartlang.org for more packages and libraries contributed by the community and the Dart team.
If you want to build Dart yourself, here is a guide to getting the source, preparing your machine to build the SDK, and building.
There are more documents on our wiki.
The easiest way to contribute to Dart is to file issues.
You can also contribute patches, as described in Contributing.