| commit | b13c4e4c9f462c9f378a93f2c09368c4093848c0 | [log] [tgz] |
|---|---|---|
| author | Daniel Hillerström <hillerstrom@google.com> | Wed Aug 15 06:52:48 2018 +0000 |
| committer | commit-bot@chromium.org <commit-bot@chromium.org> | Wed Aug 15 06:52:48 2018 +0000 |
| tree | 7d5b150a752e3664102a0b142a6dc59801fe9aa0 | |
| parent | a517d197883190f5f6360594bc3b7e8d9cff4305 [diff] |
Updates status file to expect MissingCompileTimeError for illegal async function return type check whenever running in 'legacy mode'. Adapts language_2_kernel.status such that a MissingCompileTimeError is expected for illegal return types of async functions when running in 'legacy mode'. Updates the commentary in finishFunction in body_builder.dart. Some legacy tests* have revealed that it may not always be correct to check whether [strongMode] is enabled before checking the return type of async functions. The reason behind the strongMode check was to ensure that [_typeInferrer.typeSchemaEnvironment] would be instantiated as per ahe's suggestion. There seems to be some inconsistency in the code base as to when [_typeInferrer.typeSchemaEnvironment] is non-null. For example, during the fasta perf benchmarks one may observe a null value, whilst it seems that the member is always non-null when running `dart --no-preview-dart-2 <script.dart>`. * test log: https://ci.chromium.org/p/dart/builders/luci.dart.ci.sandbox/front-end-legacy-linux-release-x64/621 Change-Id: I2211bfe0ae75a7aa35e2d698ff5cba27af484d07 Bug: 33425 Reviewed-on: https://dart-review.googlesource.com/69920 Commit-Queue: Daniel Hillerström <hillerstrom@google.com> Reviewed-by: Aske Simon Christensen <askesc@google.com>
Dart is an open-source, scalable programming language, with robust libraries and runtimes, for building web, server, and mobile apps.
Visit the dartlang.org to learn more about the language, tools, getting started, and more.
Browse pub.dartlang.org for more packages and libraries contributed by the community and the Dart team.
If you want to build Dart yourself, here is a guide to getting the source, preparing your machine to build the SDK, and building.
There are more documents on our wiki.
The easiest way to contribute to Dart is to file issues.
You can also contribute patches, as described in Contributing.