| commit | b03e7c75f159ad8f6a46726f8cde9e72fd817e11 | [log] [tgz] |
|---|---|---|
| author | Sam Rawlins <srawlins@google.com> | Thu Mar 20 09:25:02 2025 -0700 |
| committer | Commit Queue <dart-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Mar 20 09:25:02 2025 -0700 |
| tree | a9eb1cc8ea3f6074dcc2bb44f0aad3c91feec01c | |
| parent | d3adf41b9af1db2c4eb930f1ac55175259e9db7d [diff] |
DAS: add_null_check - Rearrange code to promote variables better The motivation here was to remove the local duplicate variable, `target_final`. This variable only existed because the variable it duplicates, `target`, loses its promoted type inside the `builder.addDartFileEdit` closure. It loses it's promoted type because it is assigned late. This CL extracts the first ~60 lines of the `compute()` method, which is solely concerned with computing the real "target". The diff looks large because of how the first ~60 lines of `compute()` is moved into a helper method that is _below_ the second half of `compute()`. I think each of these changes then improves readability: extracting part of a 170-line long method into one helper, and avoiding a local duplicate variable. Change-Id: I20e2eb3479f53810d4dfcab9b88ebacb446e0f62 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/416884 Commit-Queue: Samuel Rawlins <srawlins@google.com> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Dart is:
Approachable: Develop with a strongly typed programming language that is consistent, concise, and offers modern language features like null safety and patterns.
Portable: Compile to ARM, x64, or RISC-V machine code for mobile, desktop, and backend. Compile to JavaScript or WebAssembly for the web.
Productive: Make changes iteratively: use hot reload to see the result instantly in your running app. Diagnose app issues using DevTools.
Dart's flexible compiler technology lets you run Dart code in different ways, depending on your target platform and goals:
Dart Native: For programs targeting devices (mobile, desktop, server, and more), Dart Native includes both a Dart VM with JIT (just-in-time) compilation and an AOT (ahead-of-time) compiler for producing machine code.
Dart Web: For programs targeting the web, Dart Web includes both a development time compiler (dartdevc) and a production time compiler (dart2js).
Dart is free and open source.
See LICENSE and PATENT_GRANT.
Visit dart.dev to learn more about the language, tools, and to find codelabs.
Browse pub.dev for more packages and libraries contributed by the community and the Dart team.
Our API reference documentation is published at api.dart.dev, based on the stable release. (We also publish docs from our beta and dev channels, as well as from the primary development branch).
If you want to build Dart yourself, here is a guide to getting the source, preparing your machine to build the SDK, and building.
There are more documents in our repo at docs.
The easiest way to contribute to Dart is to file issues.
You can also contribute patches, as described in Contributing.
Future plans for Dart are included in the combined Dart and Flutter roadmap on the Flutter wiki.