| commit | ac901b52bf1122c63a9a60ecebe24020d14dec51 | [log] [tgz] |
|---|---|---|
| author | Kallen Tu <kallentu@google.com> | Wed Aug 23 18:05:47 2023 +0000 |
| committer | Commit Queue <dart-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Aug 23 18:05:47 2023 +0000 |
| tree | 28d9b1e5638d60685ff2ddb7b971b0c0223887c4 | |
| parent | 28434dfa83c80a34e8e8080566e5a4acece7448d [diff] |
[analyzer] Avoid evaluating the argument list of an InstanceCreation if not const. Fixes a breakage caused by https://dart-review.googlesource.com/c/sdk/+/319911. This reverts a mistake in evaluating the argument list for constant errors if it's not even constant. b/297178967 Change-Id: I88db872025d10dd75e07d1349ceef61bc251cfc2 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/322441 Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> Commit-Queue: Kallen Tu <kallentu@google.com>
diff --git a/pkg/analyzer/lib/src/dart/constant/constant_verifier.dart b/pkg/analyzer/lib/src/dart/constant/constant_verifier.dart index 806b03c..0e61867 100644 --- a/pkg/analyzer/lib/src/dart/constant/constant_verifier.dart +++ b/pkg/analyzer/lib/src/dart/constant/constant_verifier.dart
@@ -263,7 +263,6 @@ } } } else { - node.argumentList.accept(this); super.visitInstanceCreationExpression(node); } }