commit abe6ad54008ac57d9b94338f5111aa7adf6d7ed7
author Paul Berry <paulberry@google.com> Thu Jun 20 22:03:39 2024 +0000
committer Commit Queue <dart-scoped@luci-project-accounts.iam.gserviceaccount.com> Thu Jun 20 22:03:39 2024 +0000
tree 56ac30f716ebeebe3b610a1db34fe83b97aba1b9
parent 6ca015ab206a4840538b7c5daabb18c5f280e554

Simplify and improve `MethodInvocationResolver._resolveReceiverDynamicBounded`

This change makes the following improvements:

- The setter for `nameNode.staticElement` is always
  invoked. Previously it was only invoked when storing a non-null
  element. In principle this shouldn't make a difference (since static
  elements default to `null`), but it should hopefully make the code a
  little easier to reason about.

- In the case where the `receiverType` is `InvalidType`, no other
  resolution is attempted. Previously, in this case, an attempt was
  still made to resolve the method invocation to a member of `Object`,
  which kind of went against the intended behavior of
  `InvalidType`. Also, if a matching member of `Object` _was_ found,
  then `nameNode.staticType` would get set more than once, making it
  more difficult for the reader to understand what the code was doing.

- In the case where the method invocation resolves to a method of
  `Object`, `nameNode.staticType` and `node.staticInvokeType` are set
  to the type of that method. Previously they were not set at all in
  this case (but they were set in all other cases).

In addition the logic is more straightforward, since the various AST
properties are always set in the same order by straightforward inline
code.

Change-Id: I246a2e9c53542b1e4b26d5197708e66e7988789d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/372561
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>