commit aa63ef8f4f506ffa9f160b960158e861be370b4a
author Devon Carew <devoncarew@google.com> Fri Apr 22 16:44:30 2022 +0000
committer Commit Bot <commit-bot@chromium.org> Fri Apr 22 16:44:30 2022 +0000
tree e48258f66538a10c6f0f848b837320e265bdcf2f
parent 6d88de709c23b3eaa5e7425608eb1cc1f8d5490f

[deps] remove the package:pedantic dep

Change-Id: Icacaa97ccd1b1919a97c50bec431c54137c08b07
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/241984
Reviewed-by: Lasse Nielsen <lrn@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>

DEPS

diff --git a/DEPS b/DEPS
index ce6e7aa..b248603 100644
--- a/DEPS
+++ b/DEPS
@@ -133,7 +133,6 @@
   "oauth2_rev": "7cd3284049fe5badbec9f2bea2afc41d14c01057",
   "package_config_rev": "8731bf10b5375542792a32a0f7c8a6f370583d96",
   "path_rev": "baedce9d2ca11ea2cdf54395a74eb038087777a4",
-  "pedantic_rev": "66f2f6c27581c7936482e83be80b27be2719901c",
   "platform_rev": "1ffad63428bbd1b3ecaa15926bacfb724023648c",
   "ply_rev": "604b32590ffad5cbb82e4afef1d305512d06ae93",
   "pool_rev": "7abe634002a1ba8a0928eded086062f1307ccfae",
@@ -380,8 +379,6 @@
       "@" + Var("package_config_rev"),
   Var("dart_root") + "/third_party/pkg/path":
       Var("dart_git") + "path.git" + "@" + Var("path_rev"),
-  Var("dart_root") + "/third_party/pkg/pedantic":
-      Var("dart_git") + "pedantic.git" + "@" + Var("pedantic_rev"),
   Var("dart_root") + "/third_party/pkg/platform":
        Var("dart_git") + "platform.dart.git" + "@" + Var("platform_rev"),
   Var("dart_root") + "/third_party/pkg/pool":

pkg/dartdev/test/core_test.dart

diff --git a/pkg/dartdev/test/core_test.dart b/pkg/dartdev/test/core_test.dart
index e06feef..dc74efa 100644
--- a/pkg/dartdev/test/core_test.dart
+++ b/pkg/dartdev/test/core_test.dart
@@ -105,7 +105,7 @@
   test('hasDependency', () {
     PackageConfig packageConfig = PackageConfig(jsonDecode(_packageData));
     expect(packageConfig.hasDependency('test'), isFalse);
-    expect(packageConfig.hasDependency('pedantic'), isTrue);
+    expect(packageConfig.hasDependency('lints'), isTrue);
   });
 }
 
@@ -149,8 +149,8 @@
   "configVersion": 2,
   "packages": [
     {
-      "name": "pedantic",
-      "rootUri": "file:///Users/.../.pub-cache/hosted/pub.dartlang.org/pedantic-1.9.0",
+      "name": "lints",
+      "rootUri": "file:///Users/.../.pub-cache/hosted/pub.dartlang.org/lints-1.0.1",
       "packageUri": "lib/",
       "languageVersion": "2.1"
     },

pkg/dartdev/test/utils_test.dart

diff --git a/pkg/dartdev/test/utils_test.dart b/pkg/dartdev/test/utils_test.dart
index 642adbe..a25734d 100644
--- a/pkg/dartdev/test/utils_test.dart
+++ b/pkg/dartdev/test/utils_test.dart
@@ -163,8 +163,8 @@
   "configVersion": 2,
   "packages": [
     {
-      "name": "pedantic",
-      "rootUri": "file:///Users/.../.pub-cache/hosted/pub.dartlang.org/pedantic-1.9.0",
+      "name": "lints",
+      "rootUri": "file:///Users/.../.pub-cache/hosted/pub.dartlang.org/lints-1.0.1",
       "packageUri": "lib/",
       "languageVersion": "2.1"
     },

tools/package_deps/bin/package_deps.dart

diff --git a/tools/package_deps/bin/package_deps.dart b/tools/package_deps/bin/package_deps.dart
index 43f2bc1..ce47f51 100644
--- a/tools/package_deps/bin/package_deps.dart
+++ b/tools/package_deps/bin/package_deps.dart
@@ -233,9 +233,9 @@
 
     var extraDevDeclarations = Set<String>.from(_declaredDevDependencies)
       ..removeAll(devdeps);
-    // Remove package:pedantic and package:lints as they are often declared as
-    // dev dependencies in order to bring in their analysis_options.yaml files.
-    extraDevDeclarations.removeAll(['lints', 'pedantic']);
+    // Remove package:lints - it's often declared as a dev dependency in order
+    // to bring in analysis_options configuration files.
+    extraDevDeclarations.removeAll(['lints']);
     if (extraDevDeclarations.isNotEmpty) {
       out('  ${_printSet(extraDevDeclarations)} declared in '
           "'dev_dependencies:' but not used in dev dirs.");