| commit | aa00d4844e7e53ee3f3016cdd26de5bfce2cd348 | [log] [tgz] |
|---|---|---|
| author | Paul Berry <paulberry@google.com> | Fri Jun 13 06:35:23 2025 -0700 |
| committer | Commit Queue <dart-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Jun 13 06:35:23 2025 -0700 |
| tree | 139e6fda3f83cd3f1d4e457aa57595fcef84b43b | |
| parent | 758ff3ab8cbfe6840a26210c67b225d7c8e9e58f [diff] |
[flow analysis] Remove skipDuplicateCheck hack. In https://dart-review.googlesource.com/c/sdk/+/278649, I added assertions to flow analysis to make sure that `FlowAnalysis.declare` wasn't called more times than necessary. To work around a few instance in which it _was_ being called more than necessary, I added a parameter `skipDuplicateCheck` that caused the assertion to be skipped. This change fixes the one remaining case in which skipping the check was necessary, by moving the CFE logic that calls `FlowAnalysis.declare` for formal parameters. Previously, this logic was in both `BodyBuilder.finishFunction` and `BodyBuilder.finishConstructor`, resulting in some duplication because `BodyBuilder.finishFunction` sometimes calls `BodyBuilder.finishConstructor`. I've moved the logic into a new method, `BodyBuilder._declareFormals`, which is called from `BodyBuilder.finishFunction` and `BodyBuilder.parseInitializers`, ensuring that the calls to `FlowAnalysis.declare` only occur once. Fixing this case allows the `skipDuplicateCheck` hack to be removed entirely. Note that there was also one place where the analyzer was also using `skipDuplicateCheck`, but it was doing so unnecessarily. Change-Id: Ic34d1b7120f05d94c53774d52eb90e4ada67415f Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/434261 Commit-Queue: Paul Berry <paulberry@google.com> Reviewed-by: Chloe Stefantsova <cstefantsova@google.com> Reviewed-by: Johnni Winther <johnniwinther@google.com>
Dart is:
Approachable: Develop with a strongly typed programming language that is consistent, concise, and offers modern language features like null safety and patterns.
Portable: Compile to ARM, x64, or RISC-V machine code for mobile, desktop, and backend. Compile to JavaScript or WebAssembly for the web.
Productive: Make changes iteratively: use hot reload to see the result instantly in your running app. Diagnose app issues using DevTools.
Dart's flexible compiler technology lets you run Dart code in different ways, depending on your target platform and goals:
Dart Native: For programs targeting devices (mobile, desktop, server, and more), Dart Native includes both a Dart VM with JIT (just-in-time) compilation and an AOT (ahead-of-time) compiler for producing machine code.
Dart Web: For programs targeting the web, Dart Web includes both a development time compiler (dartdevc) and a production time compiler (dart2js).
Dart is free and open source.
See LICENSE and PATENT_GRANT.
Visit dart.dev to learn more about the language, tools, and to find codelabs.
Browse pub.dev for more packages and libraries contributed by the community and the Dart team.
Our API reference documentation is published at api.dart.dev, based on the stable release. (We also publish docs from our beta and dev channels, as well as from the primary development branch).
If you want to build Dart yourself, here is a guide to getting the source, preparing your machine to build the SDK, and building.
There are more documents in our repo at docs.
The easiest way to contribute to Dart is to file issues.
You can also contribute patches, as described in Contributing.
Future plans for Dart are included in the combined Dart and Flutter roadmap on the Flutter wiki.