| commit | a9178a20fcdaa8758d9d8be40be22fa8ad64da3c | [log] [tgz] |
|---|---|---|
| author | Jonas Finnemann Jensen <jonasfj@google.com> | Mon Aug 13 12:28:54 2018 +0000 |
| committer | Jonas Jensen <jonasfj@google.com> | Mon Aug 13 12:28:54 2018 +0000 |
| tree | 55fec1e7317cc40e25995440e03850c446ee6e17 | |
| parent | b244c0805d9741510526566d69b5cf0f9eacf303 [diff] |
Documented issues with HttpClient.authenticate Retries following `HttpClient.authenticate` does not include the original request payload, this is an issue as POST, PUT, PATCH request can be retried through this mechanism. This patch advices of the issue and suggests using `HttpClient.AddCredentials` directly or setting the `'authorization'` header manually. Closes https://github.com/dart-lang/sdk/issues/28012 --- It is possible that we should use even stronger language. It is not immediately obvious to me when the `HttpClient.authenticate` property is useful. But retrying POST, PUT, PATCH requests without sending the body again is problematic. Perhaps we should print a warning when requests with a payload a retries. Or maybe even deprecate the `HttpClient.authenticate` property. I'm new here so please educate me on the useful use-cases. Change-Id: Iaddba39c2fbb08fd31dda77bf19b9856bfa947f3 Reviewed-on: https://dart-review.googlesource.com/69161 Reviewed-by: Martin Kustermann <kustermann@google.com>
Dart is an open-source, scalable programming language, with robust libraries and runtimes, for building web, server, and mobile apps.
Visit the dartlang.org to learn more about the language, tools, getting started, and more.
Browse pub.dartlang.org for more packages and libraries contributed by the community and the Dart team.
If you want to build Dart yourself, here is a guide to getting the source, preparing your machine to build the SDK, and building.
There are more documents on our wiki.
The easiest way to contribute to Dart is to file issues.
You can also contribute patches, as described in Contributing.