[analyzer,parser] Check for named before positional in analyzer
Since the check or the absence of the check for a named argument
appearing before a positional parameter is feature-specific
considering the language feature that allows placing the named
arguments anywhere, it should be performed by the listeners of the
parser and guarded by an experiment flag, in alignment with other
experimental featuers. This CL moves the check and the reporting of
the error from the parser into the Analyzer, so that later this check
can be skipped if the corresponding experiment flag is enabled.
Part of https://github.com/dart-lang/sdk/issues/47451.
Change-Id: Ib795d418af429ee04ecfff6dfa71ec1e836fe798
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/216640
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Chloe Stefantsova <dmitryas@google.com>
diff --git a/pkg/_fe_analyzer_shared/lib/src/parser/parser_impl.dart b/pkg/_fe_analyzer_shared/lib/src/parser/parser_impl.dart
index 896bede..0f466bf 100644
--- a/pkg/_fe_analyzer_shared/lib/src/parser/parser_impl.dart
+++ b/pkg/_fe_analyzer_shared/lib/src/parser/parser_impl.dart
@@ -6446,7 +6446,6 @@
assert(optional('(', begin));
listener.beginArguments(begin);
int argumentCount = 0;
- bool hasSeenNamedArgument = false;
bool old = mayParseFunctionExpressions;
mayParseFunctionExpressions = true;
while (true) {
@@ -6461,10 +6460,6 @@
ensureIdentifier(token, IdentifierContext.namedArgumentReference)
.next!;
colon = token;
- hasSeenNamedArgument = true;
- } else if (hasSeenNamedArgument) {
- // Positional argument after named argument.
- reportRecoverableError(next, codes.messagePositionalAfterNamedArgument);
}
token = parseExpression(token);
next = token.next!;
diff --git a/pkg/analyzer/lib/src/fasta/ast_builder.dart b/pkg/analyzer/lib/src/fasta/ast_builder.dart
index 95ab07b..4951088 100644
--- a/pkg/analyzer/lib/src/fasta/ast_builder.dart
+++ b/pkg/analyzer/lib/src/fasta/ast_builder.dart
@@ -26,6 +26,7 @@
messageMissingAssignableSelector,
messageNativeClauseShouldBeAnnotation,
messageOperatorWithTypeParameters,
+ messagePositionalAfterNamedArgument,
templateDuplicateLabelInSwitchStatement,
templateExpectedButGot,
templateExpectedIdentifier,
@@ -577,6 +578,18 @@
var expressions = popTypedList2<Expression>(count);
ArgumentList arguments =
ast.argumentList(leftParenthesis, expressions, rightParenthesis);
+
+ bool hasSeenNamedArgument = false;
+ for (Expression expression in expressions) {
+ if (expression is NamedExpression) {
+ hasSeenNamedArgument = true;
+ } else if (hasSeenNamedArgument) {
+ // Positional argument after named argument.
+ handleRecoverableError(messagePositionalAfterNamedArgument,
+ expression.beginToken, expression.endToken);
+ }
+ }
+
push(ast.methodInvocation(
null, null, _tmpSimpleIdentifier(), null, arguments));
}
diff --git a/pkg/front_end/parser_testcases/error_recovery/bracket_mismatch_01.dart.expect b/pkg/front_end/parser_testcases/error_recovery/bracket_mismatch_01.dart.expect
index c15e3f8..fbbb63a 100644
--- a/pkg/front_end/parser_testcases/error_recovery/bracket_mismatch_01.dart.expect
+++ b/pkg/front_end/parser_testcases/error_recovery/bracket_mismatch_01.dart.expect
@@ -1,17 +1,5 @@
Problems reported:
-parser/error_recovery/bracket_mismatch_01:25:11: Place positional arguments before named arguments.
- D(),
- ^
-
-parser/error_recovery/bracket_mismatch_01:26:11: Place positional arguments before named arguments.
- D(),
- ^
-
-parser/error_recovery/bracket_mismatch_01:27:9: Place positional arguments before named arguments.
- ]),
- ^
-
parser/error_recovery/bracket_mismatch_01:27:9: Expected an identifier, but got ']'.
]),
^
@@ -186,19 +174,16 @@
endArguments(0, (, ))
handleSend(D, ,)
handleNamedArgument(:)
- handleRecoverableError(PositionalAfterNamedArgument, D, D)
handleIdentifier(D, expression)
handleNoTypeArguments(()
beginArguments(()
endArguments(0, (, ))
handleSend(D, ,)
- handleRecoverableError(PositionalAfterNamedArgument, D, D)
handleIdentifier(D, expression)
handleNoTypeArguments(()
beginArguments(()
endArguments(0, (, ))
handleSend(D, ,)
- handleRecoverableError(PositionalAfterNamedArgument, ], ])
handleRecoverableError(Message[ExpectedIdentifier, Expected an identifier, but got ']'., Try inserting an identifier before ']'., {lexeme: ]}], ], ])
handleIdentifier(, expression)
handleNoTypeArguments(])
diff --git a/pkg/front_end/parser_testcases/error_recovery/bracket_mismatch_01.dart.intertwined.expect b/pkg/front_end/parser_testcases/error_recovery/bracket_mismatch_01.dart.intertwined.expect
index ea9535d..594b6db 100644
--- a/pkg/front_end/parser_testcases/error_recovery/bracket_mismatch_01.dart.intertwined.expect
+++ b/pkg/front_end/parser_testcases/error_recovery/bracket_mismatch_01.dart.intertwined.expect
@@ -414,8 +414,6 @@
listener: endArguments(0, (, ))
listener: handleSend(D, ,)
listener: handleNamedArgument(:)
- reportRecoverableError(D, PositionalAfterNamedArgument)
- listener: handleRecoverableError(PositionalAfterNamedArgument, D, D)
parseExpression(,)
parsePrecedenceExpression(,, 1, true)
parseUnaryExpression(,, true)
@@ -433,8 +431,6 @@
listener: beginArguments(()
listener: endArguments(0, (, ))
listener: handleSend(D, ,)
- reportRecoverableError(D, PositionalAfterNamedArgument)
- listener: handleRecoverableError(PositionalAfterNamedArgument, D, D)
parseExpression(,)
parsePrecedenceExpression(,, 1, true)
parseUnaryExpression(,, true)
@@ -452,8 +448,6 @@
listener: beginArguments(()
listener: endArguments(0, (, ))
listener: handleSend(D, ,)
- reportRecoverableError(], PositionalAfterNamedArgument)
- listener: handleRecoverableError(PositionalAfterNamedArgument, ], ])
parseExpression(,)
parsePrecedenceExpression(,, 1, true)
parseUnaryExpression(,, true)
diff --git a/pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart.strong.expect b/pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart.strong.expect
index c92d158..2f58211 100644
--- a/pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart.strong.expect
+++ b/pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart.strong.expect
@@ -1,177 +1,4 @@
library /*isNonNullableByDefault*/;
-//
-// Problems in library:
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:17:21: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// method2(foo: 1, 2); // This call.
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:27:16: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// foo(1, z: 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:28:13: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// foo(z: 1, 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:28:16: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// foo(z: 1, 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:32:22: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// new A.foo(1, z: 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:33:19: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// new A.foo(z: 1, 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:33:22: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// new A.foo(z: 1, 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:35:22: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// new B.foo(1, z: 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:36:19: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// new B.foo(z: 1, 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:36:22: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// new B.foo(z: 1, 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:40:18: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// new A(1, z: 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:41:15: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// new A(z: 1, 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:41:18: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// new A(z: 1, 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:43:18: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// new B(1, z: 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:44:15: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// new B(z: 1, 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:44:18: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// new B(z: 1, 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:48:14: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// d(1, z: 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:49:11: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// d(z: 1, 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:49:14: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// d(z: 1, 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:53:14: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// f(1, z: 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:54:11: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// f(z: 1, 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:54:14: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// f(z: 1, 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:58:23: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// a.property(1, z: 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:59:20: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// a.property(z: 1, 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:59:23: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// a.property(z: 1, 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:63:18: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// a.bar(1, z: 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:64:15: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// a.bar(z: 1, 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:64:18: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// a.bar(z: 1, 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:68:18: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// local(1, z: 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:69:15: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// local(z: 1, 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:69:18: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// local(z: 1, 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:77:24: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// super.bar(1, z: 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:78:21: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// super.bar(z: 1, 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:78:24: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// super.bar(z: 1, 2, 3);
-// ^
-//
import self as self;
import "dart:core" as core;
diff --git a/pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart.strong.transformed.expect b/pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart.strong.transformed.expect
index 82faf76..4cfee0f 100644
--- a/pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart.strong.transformed.expect
+++ b/pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart.strong.transformed.expect
@@ -1,177 +1,4 @@
library /*isNonNullableByDefault*/;
-//
-// Problems in library:
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:17:21: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// method2(foo: 1, 2); // This call.
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:27:16: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// foo(1, z: 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:28:13: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// foo(z: 1, 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:28:16: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// foo(z: 1, 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:32:22: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// new A.foo(1, z: 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:33:19: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// new A.foo(z: 1, 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:33:22: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// new A.foo(z: 1, 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:35:22: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// new B.foo(1, z: 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:36:19: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// new B.foo(z: 1, 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:36:22: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// new B.foo(z: 1, 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:40:18: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// new A(1, z: 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:41:15: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// new A(z: 1, 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:41:18: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// new A(z: 1, 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:43:18: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// new B(1, z: 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:44:15: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// new B(z: 1, 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:44:18: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// new B(z: 1, 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:48:14: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// d(1, z: 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:49:11: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// d(z: 1, 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:49:14: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// d(z: 1, 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:53:14: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// f(1, z: 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:54:11: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// f(z: 1, 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:54:14: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// f(z: 1, 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:58:23: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// a.property(1, z: 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:59:20: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// a.property(z: 1, 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:59:23: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// a.property(z: 1, 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:63:18: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// a.bar(1, z: 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:64:15: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// a.bar(z: 1, 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:64:18: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// a.bar(z: 1, 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:68:18: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// local(1, z: 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:69:15: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// local(z: 1, 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:69:18: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// local(z: 1, 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:77:24: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// super.bar(1, z: 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:78:21: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// super.bar(z: 1, 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:78:24: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// super.bar(z: 1, 2, 3);
-// ^
-//
import self as self;
import "dart:core" as core;
diff --git a/pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart.weak.expect b/pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart.weak.expect
index c92d158..2f58211 100644
--- a/pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart.weak.expect
+++ b/pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart.weak.expect
@@ -1,177 +1,4 @@
library /*isNonNullableByDefault*/;
-//
-// Problems in library:
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:17:21: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// method2(foo: 1, 2); // This call.
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:27:16: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// foo(1, z: 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:28:13: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// foo(z: 1, 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:28:16: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// foo(z: 1, 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:32:22: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// new A.foo(1, z: 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:33:19: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// new A.foo(z: 1, 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:33:22: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// new A.foo(z: 1, 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:35:22: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// new B.foo(1, z: 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:36:19: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// new B.foo(z: 1, 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:36:22: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// new B.foo(z: 1, 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:40:18: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// new A(1, z: 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:41:15: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// new A(z: 1, 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:41:18: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// new A(z: 1, 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:43:18: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// new B(1, z: 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:44:15: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// new B(z: 1, 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:44:18: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// new B(z: 1, 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:48:14: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// d(1, z: 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:49:11: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// d(z: 1, 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:49:14: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// d(z: 1, 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:53:14: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// f(1, z: 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:54:11: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// f(z: 1, 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:54:14: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// f(z: 1, 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:58:23: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// a.property(1, z: 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:59:20: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// a.property(z: 1, 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:59:23: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// a.property(z: 1, 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:63:18: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// a.bar(1, z: 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:64:15: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// a.bar(z: 1, 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:64:18: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// a.bar(z: 1, 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:68:18: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// local(1, z: 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:69:15: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// local(z: 1, 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:69:18: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// local(z: 1, 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:77:24: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// super.bar(1, z: 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:78:21: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// super.bar(z: 1, 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:78:24: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// super.bar(z: 1, 2, 3);
-// ^
-//
import self as self;
import "dart:core" as core;
diff --git a/pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart.weak.transformed.expect b/pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart.weak.transformed.expect
index 82faf76..4cfee0f 100644
--- a/pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart.weak.transformed.expect
+++ b/pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart.weak.transformed.expect
@@ -1,177 +1,4 @@
library /*isNonNullableByDefault*/;
-//
-// Problems in library:
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:17:21: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// method2(foo: 1, 2); // This call.
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:27:16: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// foo(1, z: 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:28:13: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// foo(z: 1, 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:28:16: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// foo(z: 1, 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:32:22: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// new A.foo(1, z: 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:33:19: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// new A.foo(z: 1, 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:33:22: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// new A.foo(z: 1, 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:35:22: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// new B.foo(1, z: 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:36:19: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// new B.foo(z: 1, 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:36:22: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// new B.foo(z: 1, 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:40:18: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// new A(1, z: 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:41:15: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// new A(z: 1, 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:41:18: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// new A(z: 1, 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:43:18: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// new B(1, z: 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:44:15: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// new B(z: 1, 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:44:18: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// new B(z: 1, 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:48:14: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// d(1, z: 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:49:11: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// d(z: 1, 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:49:14: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// d(z: 1, 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:53:14: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// f(1, z: 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:54:11: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// f(z: 1, 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:54:14: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// f(z: 1, 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:58:23: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// a.property(1, z: 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:59:20: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// a.property(z: 1, 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:59:23: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// a.property(z: 1, 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:63:18: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// a.bar(1, z: 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:64:15: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// a.bar(z: 1, 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:64:18: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// a.bar(z: 1, 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:68:18: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// local(1, z: 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:69:15: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// local(z: 1, 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:69:18: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// local(z: 1, 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:77:24: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// super.bar(1, z: 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:78:21: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// super.bar(z: 1, 2, 3);
-// ^
-//
-// pkg/front_end/testcases/unscheduled_experiments/named_arguments_anywhere/all_kinds.dart:78:24: Error: Place positional arguments before named arguments.
-// Try moving the positional argument before the named arguments, or add a name to the argument.
-// super.bar(z: 1, 2, 3);
-// ^
-//
import self as self;
import "dart:core" as core;
