| commit | a528b19d2c62eff86dc262409f9f873c78e23305 | [log] [tgz] |
|---|---|---|
| author | Regis Crelier <regis@google.com> | Fri Aug 07 00:01:49 2020 +0000 |
| committer | commit-bot@chromium.org <commit-bot@chromium.org> | Fri Aug 07 00:01:49 2020 +0000 |
| tree | c9429dbfd07d554e69ec36a0a95472f6a914dbc5 | |
| parent | 83d962339e33bc9325f6f18b871d5ab24298f3a3 [diff] |
[VM/runtime] Fix computation of the hash of recursive types. When computing the hash of a type, only include the hashes of the type arguments corresponding to the type parameters of the type's class and not of the whole type argument vector, otherwise, the variable location of TypeRefs in the base class type arguments may result in different hashes. Add a regression test (this test was not failing in all configurations, since the issue becomes visible depending on the order in which types are loaded and finalized). This fixes issue https://github.com/dart-lang/sdk/issues/42954 Small improvement: pick hash value 1 for a vector of dynamic types, so it can be cached and not recomputed repeatedly, which was the case with value 0. Change-Id: I3468952cbf61944a82cf8e00efbf4952bd831fbe Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/157563 Reviewed-by: Alexander Markov <alexmarkov@google.com> Commit-Queue: Régis Crelier <regis@google.com>
Dart is:
Optimized for UI: Develop with a programming language specialized around the needs of user interface creation
Productive: Make changes iteratively: use hot reload to see the result instantly in your running app
Fast on all platforms: Compile to ARM & x64 machine code for mobile, desktop, and backend. Or compile to JavaScript for the web
Dart's flexible compiler technology lets you run Dart code in different ways, depending on your target platform and goals:
Dart Native: For programs targeting devices (mobile, desktop, server, and more), Dart Native includes both a Dart VM with JIT (just-in-time) compilation and an AOT (ahead-of-time) compiler for producing machine code.
Dart Web: For programs targeting the web, Dart Web includes both a development time compiler (dartdevc) and a production time compiler (dart2js).
Dart is free and open source.
See LICENSE and PATENT_GRANT.
Visit the dart.dev to learn more about the language, tools, getting started, and more.
Browse pub.dev for more packages and libraries contributed by the community and the Dart team.
If you want to build Dart yourself, here is a guide to getting the source, preparing your machine to build the SDK, and building.
There are more documents on our wiki.
The easiest way to contribute to Dart is to file issues.
You can also contribute patches, as described in Contributing.