| commit | 70d5cf8578111119dcfabee1540610909b70cf1a | [log] [tgz] |
|---|---|---|
| author | Martin Kustermann <kustermann@google.com> | Fri Oct 19 10:03:41 2018 +0000 |
| committer | commit-bot@chromium.org <commit-bot@chromium.org> | Fri Oct 19 10:03:41 2018 +0000 |
| tree | e603fa09387140f9de64342de12452cb6072d7bd | |
| parent | cfbb70aa1cc24567bbb5fdfaed34e708a7603e41 [diff] |
[VM] Rehash constant tables after cid-renumbering during app-jit training When sorting classes during app-jit training we permute the class ids. This makes canonical hash codes which depend directly (or indirectly) on class ids change. We already clear out the cached canonical hash codes in type-related instances in the heap. Though the cid renumbering makes the non-cached canonical hashcodes of other objects, such as canonical Instance and Array objects, also change. This means any data structures which use canonical hash codes of type related objects or Instance/Array objects need to re-hash. -> This CL makes us rehash the constant tables after cid renumbering. Fixes https://github.com/dart-lang/sdk/issues/34849 Change-Id: Icfb5add3f14e2c62c5bca94f296133121ad0bc55 Reviewed-on: https://dart-review.googlesource.com/c/80801 Commit-Queue: Martin Kustermann <kustermann@google.com> Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Dart is an open-source, scalable programming language, with robust libraries and runtimes, for building web, server, and mobile apps.
Visit the dartlang.org to learn more about the language, tools, getting started, and more.
Browse pub.dartlang.org for more packages and libraries contributed by the community and the Dart team.
If you want to build Dart yourself, here is a guide to getting the source, preparing your machine to build the SDK, and building.
There are more documents on our wiki.
The easiest way to contribute to Dart is to file issues.
You can also contribute patches, as described in Contributing.