commit | a474f49adad1204ba6f4fe9e74a4cb97881dacf1 | [log] [tgz] |
---|---|---|
author | Alexander Markov <alexmarkov@google.com> | Fri Oct 19 03:41:17 2018 +0000 |
committer | commit-bot@chromium.org <commit-bot@chromium.org> | Fri Oct 19 03:41:17 2018 +0000 |
tree | a250e8e09c6105be1414c84eac4a4f4ee24d33b4 | |
parent | e9b8e2489174850eaed40b0dc8ea0faed768fa83 [diff] |
Revert "[vm/interpreter] Fix interpreter frame recognition in stack walking" This reverts commit a0cc3e2684b7e3b29cb6126a899ac749c163c444. Reason for revert: broken precompiler bots Original change's description: > [vm/interpreter] Fix interpreter frame recognition in stack walking > > When GC is visiting pointers, it scans mutator thread even if it is not > active. It could happen if a thread has (temporarily) exitted isolate. > In such case, stack frame iteration would not find interpreter and > would not recognize interpreter frames. An attempt to visit interpreter > frame as non-interpreter causes crashes/assertions. > > The fix is to move interpreter from Isolate to Thread. This way > interpreter is available for stack walking even if thread doesn't have > isolate. > > Change-Id: Iff12ce7391b19a6f87bd4fac94137cba5623dfb9 > Reviewed-on: https://dart-review.googlesource.com/c/80760 > Reviewed-by: RĂ©gis Crelier <regis@google.com> > Commit-Queue: Alexander Markov <alexmarkov@google.com> TBR=rmacnak@google.com,alexmarkov@google.com,zra@google.com,asiva@google.com,regis@google.com Change-Id: Ic4d73536eadb6601ee323918c65f5f2b2b2b2418 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://dart-review.googlesource.com/c/80781 Reviewed-by: Alexander Markov <alexmarkov@google.com> Commit-Queue: Alexander Markov <alexmarkov@google.com>
Dart is an open-source, scalable programming language, with robust libraries and runtimes, for building web, server, and mobile apps.
Visit the dartlang.org to learn more about the language, tools, getting started, and more.
Browse pub.dartlang.org for more packages and libraries contributed by the community and the Dart team.
If you want to build Dart yourself, here is a guide to getting the source, preparing your machine to build the SDK, and building.
There are more documents on our wiki.
The easiest way to contribute to Dart is to file issues.
You can also contribute patches, as described in Contributing.