| commit | a43d3cb993e559b86fbe091283e0aaa9236097cb | [log] [tgz] |
|---|---|---|
| author | Tess Strickland <sstrickl@google.com> | Thu Dec 08 12:58:28 2022 +0000 |
| committer | Commit Queue <dart-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Dec 08 12:58:28 2022 +0000 |
| tree | a7cffcbc6cc7b48c450a8f98a306d67237cdb473 | |
| parent | 3f3c6b4b8ceb2e135bd11d5cdabcb0976c43919f [diff] |
[vm/compiler] Use CombineHashes/FinalizeHash methods in intrinsifier. AsmIntrinsifier::OneByteString_getHashCode now uses the CombineHashes and FinalizeHash Assembler methods introduced in 49f998dc31. To avoid having to check for 0 again after masking the result of FinalizeHash to fit the desired bit size, we create a more general FinalizeHashForSize that also takes the desired bit size of the result. The intrinsified versions for ARM/ARM64/RISCV are also modified to remove the special casing for the empty string, and instead just check the size of the string against the loop counter at the start of the loop, similarly to X64/IA32. This is less efficient for the empty string case, but avoids the need to create a version of FinalizeHash that elides the zero check. TEST=ci Cq-Include-Trybots: luci.dart.try:vm-kernel-precomp-dwarf-linux-product-x64-try,vm-kernel-precomp-linux-product-x64-try,vm-kernel-precomp-linux-release-x64-try,vm-kernel-precomp-nnbd-mac-release-arm64-try,vm-kernel-precomp-nnbd-linux-release-simarm_x64-try,vm-kernel-precomp-linux-release-simarm-try,vm-kernel-precomp-nnbd-linux-release-x64-try,vm-kernel-precomp-nnbd-linux-release-simarm64-try,vm-kernel-precomp-nnbd-linux-debug-simriscv64-try,vm-kernel-precomp-linux-debug-x64c-try,vm-kernel-nnbd-linux-debug-simriscv64-try,vm-kernel-linux-release-simarm-try,vm-kernel-linux-release-simarm64-try,vm-kernel-linux-release-ia32-try,vm-kernel-nnbd-linux-release-simarm-try,vm-kernel-nnbd-linux-release-simarm64-try,vm-kernel-nnbd-linux-release-ia32-try,vm-kernel-nnbd-mac-release-arm64-try,vm-kernel-linux-debug-x64c-try Change-Id: I53db731acb8bf35d16efb55fa2c5a79d8302399f Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/272800 Reviewed-by: Daco Harkes <dacoharkes@google.com> Commit-Queue: Tess Strickland <sstrickl@google.com>
Dart is:
Optimized for UI: Develop with a programming language specialized around the needs of user interface creation.
Productive: Make changes iteratively: use hot reload to see the result instantly in your running app.
Fast on all platforms: Compile to ARM & x64 machine code for mobile, desktop, and backend. Or compile to JavaScript for the web.
Dart's flexible compiler technology lets you run Dart code in different ways, depending on your target platform and goals:
Dart Native: For programs targeting devices (mobile, desktop, server, and more), Dart Native includes both a Dart VM with JIT (just-in-time) compilation and an AOT (ahead-of-time) compiler for producing machine code.
Dart Web: For programs targeting the web, Dart Web includes both a development time compiler (dartdevc) and a production time compiler (dart2js).
Dart is free and open source.
See LICENSE and PATENT_GRANT.
Visit dart.dev to learn more about the language, tools, and to find codelabs.
Browse pub.dev for more packages and libraries contributed by the community and the Dart team.
Our API reference documentation is published at api.dart.dev, based on the stable release. (We also publish docs from our beta and dev channels, as well as from the primary development branch).
If you want to build Dart yourself, here is a guide to getting the source, preparing your machine to build the SDK, and building.
There are more documents on our wiki.
The easiest way to contribute to Dart is to file issues.
You can also contribute patches, as described in Contributing.