Add a check for validating method name
Change-Id: Ia312b8c64c01a809b4ae98d0469b755e959dbd16
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239321
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Keerti Parthasarathy <keertip@google.com>
diff --git a/pkg/analysis_server/lib/src/cider/rename.dart b/pkg/analysis_server/lib/src/cider/rename.dart
index 34e97b2..84ef2e3 100644
--- a/pkg/analysis_server/lib/src/cider/rename.dart
+++ b/pkg/analysis_server/lib/src/cider/rename.dart
@@ -39,6 +39,8 @@
status = validateFunctionName(name);
} else if (element is FieldElement) {
status = validateFieldName(name);
+ } else if (element is MethodElement) {
+ status = validateMethodName(name);
} else if (element is TypeAliasElement) {
status = validateTypeAliasName(name);
} else if (element is ClassElement) {
diff --git a/pkg/analysis_server/test/src/cider/rename_test.dart b/pkg/analysis_server/test/src/cider/rename_test.dart
index 0147ec9..ac912a4 100644
--- a/pkg/analysis_server/test/src/cider/rename_test.dart
+++ b/pkg/analysis_server/test/src/cider/rename_test.dart
@@ -359,6 +359,29 @@
[CharacterLocation(2, 7), CharacterLocation(2, 22)]));
}
+ void test_rename_method_imported() async {
+ var a = newFile2('/workspace/dart/test/lib/a.dart', r'''
+class A {
+ foo() {}
+}
+''');
+ await fileResolver.resolve2(path: a.path);
+ var result = await _rename(r'''
+import 'a.dart';
+void f() {
+ var a = A().^foo();
+}
+''', 'bar');
+ expect(result!.matches.length, 2);
+ expect(result.matches, [
+ CiderSearchMatch(convertPath('/workspace/dart/test/lib/a.dart'), [
+ CharacterLocation(2, 3),
+ ]),
+ CiderSearchMatch(convertPath('/workspace/dart/test/lib/test.dart'),
+ [CharacterLocation(3, 15)])
+ ]);
+ }
+
void test_rename_parameter() async {
var result = await _rename(r'''
void foo(String ^a) {
