| commit | a2b26effb0e5e19ccaf926121a4c38182f5a8be6 | [log] [tgz] |
|---|---|---|
| author | Daco Harkes <dacoharkes@google.com> | Thu Jun 20 14:36:36 2024 +0000 |
| committer | Commit Queue <dart-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Jun 20 14:36:36 2024 +0000 |
| tree | a6551644d57828ac4b19578ac4a555ba1f429033 | |
| parent | 7f370d1134a861c9c8fc2fc7824a346bc1a8925e [diff] |
[vm] Native asset path resolution symlinks with spaces This CL fixes symlink resolution by properly decoding a URI to a file path before doing symlink resolution (on the file path). File paths have spaces, but URIs can be encoded with percent encoding. Before resolving the relative paths, the symlink-resolved script path is encoded as URI again. This encoding is trivial (percentage encoding is optional), so it only needs to prepend a scheme. Also, this CL improves the error message for the relative path resolution if the dylib cannot be found to include the script uri. TEST=tests/ffi/native_assets/asset_relative_test.dart Closes: https://github.com/dart-lang/sdk/issues/56053 Change-Id: I3ac9748e971e6eacbe14f3485bf3a3943d587d7d Cq-Include-Trybots: dart/try:vm-aot-asan-linux-release-x64-try,vm-aot-linux-debug-x64-try,vm-aot-linux-debug-x64c-try,vm-aot-mac-release-arm64-try,vm-aot-mac-release-x64-try,vm-aot-msan-linux-release-x64-try,vm-aot-obfuscate-linux-release-x64-try,vm-aot-optimization-level-linux-release-x64-try,vm-aot-tsan-linux-release-x64-try,vm-aot-ubsan-linux-release-x64-try,vm-aot-win-debug-arm64-try,vm-aot-win-debug-x64-try,vm-aot-win-debug-x64c-try,vm-asan-linux-release-arm64-try,vm-msan-linux-release-arm64-try,vm-tsan-linux-release-arm64-try,vm-ubsan-linux-release-arm64-try Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/372421 Reviewed-by: Martin Kustermann <kustermann@google.com> Commit-Queue: Daco Harkes <dacoharkes@google.com>
Dart is:
Approachable: Develop with a strongly typed programming language that is consistent, concise, and offers modern language features like null safety and patterns.
Portable: Compile to ARM, x64, or RISC-V machine code for mobile, desktop, and backend. Compile to JavaScript or WebAssembly for the web.
Productive: Make changes iteratively: use hot reload to see the result instantly in your running app. Diagnose app issues using DevTools.
Dart's flexible compiler technology lets you run Dart code in different ways, depending on your target platform and goals:
Dart Native: For programs targeting devices (mobile, desktop, server, and more), Dart Native includes both a Dart VM with JIT (just-in-time) compilation and an AOT (ahead-of-time) compiler for producing machine code.
Dart Web: For programs targeting the web, Dart Web includes both a development time compiler (dartdevc) and a production time compiler (dart2js).
Dart is free and open source.
See LICENSE and PATENT_GRANT.
Visit dart.dev to learn more about the language, tools, and to find codelabs.
Browse pub.dev for more packages and libraries contributed by the community and the Dart team.
Our API reference documentation is published at api.dart.dev, based on the stable release. (We also publish docs from our beta and dev channels, as well as from the primary development branch).
If you want to build Dart yourself, here is a guide to getting the source, preparing your machine to build the SDK, and building.
There are more documents in our repo at docs.
The easiest way to contribute to Dart is to file issues.
You can also contribute patches, as described in Contributing.
Future plans for Dart are included in the combined Dart and Flutter roadmap on the Flutter wiki.