tree 32ae5e5a44dee3be780a0375c8f8b733ef5063c7
parent 5dab28f27f525b8e2b88f0dfa19f03c5619f3234
author Aart Bik <ajcbik@google.com> 1548283717 +0000
committer commit-bot@chromium.org <commit-bot@chromium.org> 1548283717 +0000

[dart/vm] Annotate _ByteDataView to reduce code size

Rationale:
Slava's excellent code size difference tools enables
very fine-grained analysis of the impact of changes.
This CL improves Flutter Gallery size by 18984 bytes.

+------------------------------------------------------+-----------------------------------------+--------------+
| Library                                              | Method                                  | Diff (Bytes) |
+------------------------------------------------------+-----------------------------------------+--------------+
| package:flutter/src/painting/decoration_image.dart   | paintImage                              |         +936 |
| dart:ui                                              | Paint.toString                          |         +592 |
| package:flutter/src/material/tab_indicator.dart      | _UnderlinePainter.paint                 |         +552 |
| package:flutter/src/material/progress_indicator.dart | _CircularProgressIndicatorPainter.paint |         +308 |
| package:flutter/src/services/message_codecs.dart     | StandardMessageCodec.readValueOfType    |         +172 |
| package:flutter/src/services/message_codecs.dart     | StandardMessageCodec.readValue          |          +60 |
| package:flutter/src/services/message_codecs.dart     | StandardMethodCodec.decodeEnvelope      |          +56 |
| package:flutter/src/services/message_codecs.dart     | StandardMethodCodec.decodeMethodCall    |          +56 |
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| package:flutter/src/widgets/semantics_debugger.dart  | _paint                                  |         -484 |
| dart:ui                                              | Paint.maskFilter=                       |         -568 |
| dart:ui                                              | Paint.colorFilter=                      |         -572 |
| package:flutter/src/painting/borders.dart            | paintBorder                             |         -656 |
| dart:ui                                              | _unpackPointerDataPacket                |         -744 |
| dart:ui                                              | Paint.isAntiAlias=                      |         -808 |
| dart:ui                                              | Paint.strokeCap=                        |         -812 |
| dart:ui                                              | Paint.filterQuality=                    |         -812 |
| dart:ui                                              | Paint.isAntiAlias                       |         -972 |
| dart:ui                                              | Paint.invertColors                      |         -976 |
+------------------------------------------------------+-----------------------------------------+--------------+
Total change -18984 bytes.

https://github.com/dart-lang/sdk/issues/35323

Change-Id: Iceeb820ed506794e1ac3e7c17f8f116a22bca742
Reviewed-on: https://dart-review.googlesource.com/c/90861
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Commit-Queue: Aart Bik <ajcbik@google.com>