)]}'
{
  "commit": "a16a6537e58d9faa7640bdd999834c6ccfff5f4a",
  "tree": "11006185af3d636b0b4b833999bee7d482c55f3e",
  "parents": [
    "5e8ee777729a34187815465ad756079dbe6d601a"
  ],
  "author": {
    "name": "Ben Konyi",
    "email": "bkonyi@google.com",
    "time": "Tue Jul 09 15:34:16 2024 +0000"
  },
  "committer": {
    "name": "Commit Queue",
    "email": "dart-scoped@luci-project-accounts.iam.gserviceaccount.com",
    "time": "Tue Jul 09 15:34:16 2024 +0000"
  },
  "message": "Reland \"Reapply \"[ Service ] Start DDS and serve DevTools when the VM service is started via dart:developer\"\"\n\nThis reverts commit 3370a4e3936d49090e176bd509ba5a1fed3b74d3.\n\nReason for revert: Fixes landed in google3 (cl/650630536).\n\nOriginal change\u0027s description:\n\u003e Revert \"Reapply \"[ Service ] Start DDS and serve DevTools when the VM service is started via dart:developer\"\"\n\u003e\n\u003e This reverts commit 44d44514761c06f201cf3d7277a558c5131e06e0.\n\u003e\n\u003e Reason for revert: b/350443042\n\u003e\n\u003e Original change\u0027s description:\n\u003e \u003e Reapply \"[ Service ] Start DDS and serve DevTools when the VM service is started via dart:developer\"\n\u003e \u003e\n\u003e \u003e In the previous version of this change, if the user had \u0027dart\u0027 on their\n\u003e \u003e PATH and invoked \u0027dart compile js\u0027 (which spawns the VM service after\n\u003e \u003e compilation completes), the VM service would attempt to spawn DDS using\n\u003e \u003e \u0027./dart\u0027 as the executable path instead of \u0027dart\u0027. This would result in\n\u003e \u003e DDS failing to start, causing the VM to print an error and hang.\n\u003e \u003e\n\u003e \u003e This updated change checks to see if the parent directory of\n\u003e \u003e `Platform.executable` is \u0027.\u0027 and then verifies if \u0027./dart\u0027 exists or\n\u003e \u003e not. If it doesn\u0027t, \u0027dart\u0027 is likely on the user\u0027s PATH and should be\n\u003e \u003e used directly as the executable path.\n\u003e \u003e\n\u003e \u003e See https://github.com/dart-lang/sdk/issues/56087 for details.\n\u003e \u003e\n\u003e \u003e This reverts commit 4b88698e4814035a356e9f1a7e6b9a9167bfa94c.\n\u003e \u003e\n\u003e \u003e TEST\u003dpkg/dds/test/control_web_server_starts_dds_with_dart_on_path_test.dart\n\u003e \u003e\n\u003e \u003e Change-Id: Id0f1dadd01d9202cbf7717f31393b43171cf3968\n\u003e \u003e Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/373561\n\u003e \u003e Auto-Submit: Ben Konyi \u003cbkonyi@google.com\u003e\n\u003e \u003e Reviewed-by: Derek Xu \u003cderekx@google.com\u003e\n\u003e \u003e Commit-Queue: Ben Konyi \u003cbkonyi@google.com\u003e\n\u003e\n\u003e Change-Id: I424c4b91b0b108ae4c9dffa0059ed90c918897e3\n\u003e Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/373744\n\u003e Reviewed-by: Siva Annamalai \u003casiva@google.com\u003e\n\u003e Bot-Commit: Rubber Stamper \u003crubber-stamper@appspot.gserviceaccount.com\u003e\n\u003e Reviewed-by: Srujan Gaddam \u003csrujzs@google.com\u003e\n\u003e Commit-Queue: Siva Annamalai \u003casiva@google.com\u003e\n\u003e Auto-Submit: Ivan Inozemtsev \u003ciinozemtsev@google.com\u003e\n\nChange-Id: Id7ddff5a80399203fb8058d84bc89fda2073da95\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/375000\nAuto-Submit: Ben Konyi \u003cbkonyi@google.com\u003e\nCommit-Queue: Ben Konyi \u003cbkonyi@google.com\u003e\nCommit-Queue: Derek Xu \u003cderekx@google.com\u003e\nReviewed-by: Derek Xu \u003cderekx@google.com\u003e\n",
  "tree_diff": [
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "e18743329abe9eb2a88de4b53119174ffa248dc9",
      "new_mode": 33188,
      "new_path": "pkg/dds/test/control_web_server_starts_dds_test.dart"
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "d498cd0c7238db16ae695f3897cfd2a76abad072",
      "new_mode": 33188,
      "new_path": "pkg/dds/test/control_web_server_starts_dds_with_dart_on_path_test.dart"
    },
    {
      "type": "modify",
      "old_id": "18498f233b420f3cc5cf57f67cae2ef1fcaf19db",
      "old_mode": 33188,
      "old_path": "runtime/observatory/tests/service/developer_server_control_test.dart",
      "new_id": "3e6c2a8b9bd7c71db7830100f4e9b676d3b5c469",
      "new_mode": 33188,
      "new_path": "runtime/observatory/tests/service/developer_server_control_test.dart"
    },
    {
      "type": "modify",
      "old_id": "d16187640b80ad4d73287af2982fea24ca0d92d0",
      "old_mode": 33188,
      "old_path": "sdk/lib/_internal/vm/bin/vmservice_io.dart",
      "new_id": "2ff457c1ed34d34e2b14d34476b71d469f1c7d5b",
      "new_mode": 33188,
      "new_path": "sdk/lib/_internal/vm/bin/vmservice_io.dart"
    }
  ]
}