| commit | 9e7b2aef2f39118a51a5884cd8edf37810be66f5 | [log] [tgz] |
|---|---|---|
| author | Jens Johansen <jensj@google.com> | Fri Sep 06 12:45:59 2024 +0000 |
| committer | Commit Queue <dart-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Sep 06 12:45:59 2024 +0000 |
| tree | a0b4c4a4b46d984f31ea2d935c57df862d1090de | |
| parent | 8c738b9d129cb77e4a5fefdb1e3f4b706b184d6d [diff] |
[CFE] Fix bug in the incremental compiler when given a part as entry With parts no longer being created up front with the correct reference (https://dart-review.googlesource.com/c/sdk/+/383620) we have a bug that can cause crashes and/or compilation errors when giving a part as entry and has that (or a sibling part or the 'parent' library) invalidated (and using advanced invalidation, i.e. no outline change). This is caused by a part-uri given as entry normally being translated to its 'parent'-librarys uri. This doesn't happen when not reusing the file though (generally it might no longer be a part). This was previously 'saved' by reading parts up front and providing the correct reference when doing the advanced invalidation, but after https://dart-review.googlesource.com/c/sdk/+/383620 it isn't. This CL fixes the issue by translating the uri correctly, i.e. when we do advanced invalidation (and it's active, i.e. there's no outline change) a part is still a part so we can translate to the parent, and when not advanced invalidating we still only translate to the parent if we reuse it (if we don't reuse it the thing that was previously a part might no longer be a part). This resolves the upload hook compile error found in https://dart-review.googlesource.com/c/sdk/+/383980 although the tests added here crashes instead of giving a compile time error. Change-Id: I13534a4ab4da5e42ea9a49ec5dc54ee811f4999a Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/383982 Reviewed-by: Johnni Winther <johnniwinther@google.com> Commit-Queue: Jens Johansen <jensj@google.com>
Dart is:
Approachable: Develop with a strongly typed programming language that is consistent, concise, and offers modern language features like null safety and patterns.
Portable: Compile to ARM, x64, or RISC-V machine code for mobile, desktop, and backend. Compile to JavaScript or WebAssembly for the web.
Productive: Make changes iteratively: use hot reload to see the result instantly in your running app. Diagnose app issues using DevTools.
Dart's flexible compiler technology lets you run Dart code in different ways, depending on your target platform and goals:
Dart Native: For programs targeting devices (mobile, desktop, server, and more), Dart Native includes both a Dart VM with JIT (just-in-time) compilation and an AOT (ahead-of-time) compiler for producing machine code.
Dart Web: For programs targeting the web, Dart Web includes both a development time compiler (dartdevc) and a production time compiler (dart2js).
Dart is free and open source.
See LICENSE and PATENT_GRANT.
Visit dart.dev to learn more about the language, tools, and to find codelabs.
Browse pub.dev for more packages and libraries contributed by the community and the Dart team.
Our API reference documentation is published at api.dart.dev, based on the stable release. (We also publish docs from our beta and dev channels, as well as from the primary development branch).
If you want to build Dart yourself, here is a guide to getting the source, preparing your machine to build the SDK, and building.
There are more documents in our repo at docs.
The easiest way to contribute to Dart is to file issues.
You can also contribute patches, as described in Contributing.
Future plans for Dart are included in the combined Dart and Flutter roadmap on the Flutter wiki.