)]}'
{
  "commit": "9e1dbb8be29e103297b8796ddc7eadbdbf912206",
  "tree": "f5a24c101a67fe87b369baac4c9c8f0c8776e230",
  "parents": [
    "8212fbeedb3f4d51a87506c2d4ddff7df9196cb9"
  ],
  "author": {
    "name": "Danny Tuppeny",
    "email": "danny@tuppeny.com",
    "time": "Thu Jan 04 17:51:58 2024 +0000"
  },
  "committer": {
    "name": "Commit Queue",
    "email": "dart-scoped@luci-project-accounts.iam.gserviceaccount.com",
    "time": "Thu Jan 04 17:51:58 2024 +0000"
  },
  "message": "[analysis_server] Remove duplicate declaration tracking from LSP server\n\nThis code appears redundant. It was adding contexts to the declarations tracker as contexts changed, but this was also being done once at the end (in the method \"addContextsToDeclarationsTracker\" mentioned in the comment).\n\nApparently at some point I added a TODO suspecting this was unnecessary but didn\u0027t realise the performance implications of it on a large project.\n\nThere are existing tests that ensure the declarations are tracked correctly (although we don\u0027t use them for completions, they\u0027re still used to resolve macros in dartdocs).\n\nSee https://github.com/dart-lang/sdk/issues/54513\n\nChange-Id: Ibdb7d00c288e78fc44c48a4f9febff688e2db323\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/344702\nReviewed-by: Brian Wilkerson \u003cbrianwilkerson@google.com\u003e\nReviewed-by: Konstantin Shcheglov \u003cscheglov@google.com\u003e\nCommit-Queue: Brian Wilkerson \u003cbrianwilkerson@google.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "8dcd72357b10ff61e7ad623dde162a1f1405f59d",
      "old_mode": 33188,
      "old_path": "pkg/analysis_server/lib/src/lsp/lsp_analysis_server.dart",
      "new_id": "b68bdb5c4a0f0be80f6c1ae3019aa2e0e794b26a",
      "new_mode": 33188,
      "new_path": "pkg/analysis_server/lib/src/lsp/lsp_analysis_server.dart"
    }
  ]
}
